ports/110687: misc/amanda-client AMANDA_PORTRANGE knob broken

[Douglas K. Rand]

>Number:         110687
>Category:       ports
>Synopsis:       misc/amanda-client AMANDA_PORTRANGE knob broken
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Mar 23 00:20:00 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Douglas K. Rand
>Release:        FreeBSD 6.2-RELEASE i386
>Organization:
Meridian Environmental Technology, Inc.
>Environment:
System: FreeBSD delta.meridian-enviro.com 6.2-RELEASE FreeBSD 6.2-RELEASE #4: Sun Jan 21 18:09:15 CST 2007 rand at delta.meridian-enviro.com:/usr/obj/usr/src/sys/DELTA i386


>Description:
	The configuration knob AMANDA_PORTRANGE nolonger works for the
	misc/amanda-client port. This happened between Amanda 2.5.0 and
	2.5.1. Rev 1.327 of Amanda's configure.in silently dropped
	support for --with-portrange in preference to the (better named)
	--with-tcpportrange.

>How-To-Repeat:
	Attempt to use amanda-client 2.5.1 or later along with the
	AMANDA_PORTRANGE knob set. The configure script will silently
	ignore the --with-portrange option.

>Fix:

	The shortest patch is trivial:


--- Makefile-orig	Thu Mar 22 18:40:50 2007
+++ Makefile	Thu Mar 22 18:41:01 2007
@@ -57,7 +57,7 @@
 .endif
 
 .if defined (AMANDA_PORTRANGE)
-CONFIGURE_ARGS+=	--with-portrange=${AMANDA_PORTRANGE}
+CONFIGURE_ARGS+=	--with-tcpportrange=${AMANDA_PORTRANGE}
 .endif
 
 .if !defined(WITHOUT_GNUTAR)


	There is a reasonable argument that the AMANDA_PORTRANGE knob
	should be renamed. I'll leave the decision to the maintainer
	if this should be changed to AMANDA_TCPPORTRANGE instead. If
	so, again the patch is trivial.
>Release-Note:
>Audit-Trail:
>Unformatted: