ports/113989: vfs recycle.so does not work well with net/samba3.

[Tsurutani Naoki]

>Number:         113989
>Category:       ports
>Synopsis:       vfs recycle.so does not work well with net/samba3.
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jun 24 14:00:09 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Tsurutani Naoki
>Release:        FreeBSD 6.2-STABLE i386
>Organization:
>Environment:
System: FreeBSD polymer3.scphys.kyoto-u.ac.jp 6.2-STABLE FreeBSD 6.2-STABLE #8: Mon Jun 4 14:16:32 JST 2007 turutani at polymer3.scphys.kyoto-u.ac.jp:/usr/local/work/usr/obj/usr/src/sys/POLYMER i386


	
>Description:
using vfs recycle.so of net/samba3 causes a error.
	Here is a log:
	[2007/05/30 12:18:18, 0] modules/vfs_recycle.c:recycle_do_touch(402)
	  recycle: touching path/to/removed_file failed, reason = Invalid argument
	With this trouble, the file is moved to a correct recycle directory,
	but the time stamp is not correct.

	
>How-To-Repeat:
Always use recycle.so vfs.
	
>Fix:
Here is a patch:
	% cat /usr/ports/net/samba3/files/patch-lib_time.c
	--- lib/time.c.orig     Sun Jun 24 20:59:49 2007
	+++ lib/time.c  Thu May 24 00:29:16 2007
	@@ -1111,7 +1111,7 @@
	        struct timespec ts;
	        GetTimeOfDay(&tv);
	        ts.tv_sec = tv.tv_sec;
	-       ts.tv_nsec = tv.tv_sec * 1000;
	+       ts.tv_nsec = tv.tv_usec * 1000;
	        return ts;
	 }

	This fix is already included in samba svn trunc.


	


>Release-Note:
>Audit-Trail:
>Unformatted: