ports/113952: [patch] bsd.ports.mk creates bad plist entry for ldconfig file

[Ben Kelly]

>Number:         113952
>Category:       ports
>Synopsis:       [patch] bsd.ports.mk creates bad plist entry for ldconfig file
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jun 22 18:40:05 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Ben Kelly
>Release:        RELENG_6
>Organization:
>Environment:
FreeBSD vir.in.vadev.org 6.2-STABLE FreeBSD 6.2-STABLE #0: Wed Jun 13 17:20:53 EDT 2007     root at vir.in.vadev.org:/usr/obj/usr/src/sys/SERVER  i386
>Description:
When a port requires an ldconfig file to be created the bsd.ports.mk make rules generate a bad plist entry in the package.  This results in messages similar to the following when deinstalling or trying to package the port:

  pkg_delete: file '(null)/libdata/ldconfig/portupgrade' doesn't really exist

The problem occurs because the plist entry is incorrectly split across two lines.  For example:

  vir# tail -3 .PLIST.mktmp
  @unexec /sbin/ldconfig -R
  @cwd
  libdata/ldconfig/portupgrade

I believe the '@cwd' and 'libdata/ldconfig/portupgrade' values should be on the same line.

Its not clear
>How-To-Repeat:
Assuming there isn't something wrong in my configuration, the following should be enough to trigger the problem.

  cd /usr/ports/ports-mgmt/portupgrade
  make install
  make deinstall
>Fix:
--- bsd.port.mk.orig    Thu Jun 14 15:09:35 2007
+++ bsd.port.mk.new     Thu Jun 14 15:10:51 2007
@@ -4008,7 +4008,7 @@
 .endif
        @${ECHO_CMD} ${USE_LDCONFIG} | ${TR} ' ' '\n' \
                > ${PREFIX}/${LDCONFIG_DIR}/${UNIQUENAME}
-       @${ECHO_CMD} "@cwd" >> ${TMPPLIST}
+       @${ECHO_CMD} -n "@cwd " >> ${TMPPLIST}
        @${ECHO_CMD} ${LDCONFIG_DIR}/${UNIQUENAME} >> ${TMPPLIST}
 .if defined(NO_LDCONFIG_MTREE)
        @${ECHO_CMD} "@unexec rmdir ${LDCONFIG_DIR} >/dev/null 2>&1 || true" >> ${TMPPLIST}


>Release-Note:
>Audit-Trail:
>Unformatted: