ports/113099: [PATCH] sysutils/libchk may skip $X11BASE now

[Akinori MUSHA]

The following reply was made to PR ports/113099; it has been noted by GNATS.

From: "Akinori MUSHA" <knu at iDaemons.org>
To: Rene Ladan <r.c.ladan at gmail.com>
Cc: Dejan Lesjak <dejan.lesjak at ijs.si>,
	freebsd-x11 at freebsd.org,
	bug-followup at freebsd.org
Subject: Re: ports/113099: [PATCH] sysutils/libchk may skip $X11BASE now
Date: Fri, 01 Jun 2007 19:49:20 +0900

 --pgp-sign-Multipart_Fri_Jun__1_19:49:20_2007-1
 Content-Type: text/plain; charset=US-ASCII
 
 Hi,
 
 At Wed, 30 May 2007 21:26:58 +0200,
 Rene Ladan wrote:
 > Dejan Lesjak wrote:
 > > USE_NONDEFAULT_X11BASE is only relevant on FreeBSD before 6.2 (as we
 > > cant set the default X11BASE in ports infrastructure there). On
 > > newer versions one can define different X11BASE even without also
 > > setting USE_NONDEFAULT_X11BASE. The ability to do that is left
 > > intentionally.
 > > Anyhow, perhaps a more general solution for libchk might be to skip
 > > $X11BASE if it is the same as $LOCALBASE?
 > >
 > This sounds reasonable.  Akinori, what do you think of the attached patch?
 
 > +  if $x11base != $localbase
 > +    $bindirs += [
 > +      "#{$x11base}/bin",
 > +      "#{$x11base}/libexec",
 > +      "#{$x11base}/sbin",
 > +    ]
 > +  end
 
 I suppose this would not make any difference to the behavior, since
 duplicated or redundant directories (descendant of another entry,
 etc.) are removed in compact_dirs!().
 
 The real problem might be that in that process libchk does not use
 realpath(3) to follow symlinks but just performs static, literal
 string matching.
 
 So if you have /usr/X11R6 symlinked to /usr/local, libchk will dive
 into the directory twice.
 
 Regards,
 
 --
                      /
                     /__  __            Akinori.org / MUSHA.org
                    / )  )  ) )  /     FreeBSD.org / Ruby-lang.org
 Akinori MUSHA aka / (_ /  ( (__(  @ iDaemons.org / and.or.jp
 
 "Different eyes see different things,
     Different hearts beat on different strings --
        But there are times for you and me when all such things agree"
 
 --pgp-sign-Multipart_Fri_Jun__1_19:49:20_2007-1
 Content-Type: application/pgp-signature
 Content-Transfer-Encoding: 7bit
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.7 (FreeBSD)
 
 iD8DBQBGX/mwkgvvx5/Z4e4RAiXPAJ0UkXVCFJ/X5NV4MruxkntJojbivQCdGYmF
 aL6f7fFTbovxqN2rChmq5+Q=
 =HhdN
 -----END PGP SIGNATURE-----
 
 --pgp-sign-Multipart_Fri_Jun__1_19:49:20_2007-1--