ports/114900: ports: net/asterisk : cannot be finished by a script

[Fumihiko Kimura]

>Number:         114900
>Category:       ports
>Synopsis:       ports: net/asterisk : cannot be finished by a script
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jul 25 14:50:07 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Fumihiko Kimura
>Release:        FreeBSD 6.2-RELEASE-p4 i386
>Organization:
>Environment:
>Description:

cc maintenor.


As for the script, a process did not stop since I became this version.

>How-To-Repeat:

#/usr/local/etc/rc.d/asterisk stop
asterisk not running? (check /var/run/asterisk.pid).
#more /var/run/asterisk/asterisk.pid
53777
#ps -ax | grep asterisk
53777  ??  Ss     0:25.70 /usr/local/sbin/asterisk
53785  p0  R+     0:00.01 grep asterisk
#ll /var/run/asterisk/
total 2
srwxr-xr-x  1 root  wheel  0 Jul 26 12:15 asterisk.ctl
-rw-r--r--  1 root  wheel  6 Jul 26 12:15 asterisk.pid
#/usr/local/sbin/asterisk -qrx 'stop now'

Disconnected from Asterisk server


>Fix:

According to the following.
But I do not understand whether this is right.
Please revise it by maintenor right.

=== begin  ===
diff -urN asterisk.orig20070725/files/asterisk.sh.in asterisk/files/asterisk.sh.in
--- asterisk.orig20070725/files/asterisk.sh.in	Sun Jul 22 19:40:35 2007
+++ asterisk/files/asterisk.sh.in	Thu Jul 26 10:37:06 2007
@@ -1,8 +1,10 @@
 #!/bin/sh
+# $FreeBSD$
 
 # PROVIDE: asterisk
 # REQUIRE: DAEMON
 # KEYWORD: shutdown
+
 #
 # Add the following lines to /etc/rc.conf to enable asterisk:
 #
@@ -11,22 +13,13 @@
 
 . %%RC_SUBR%%
 
-stop_precmd=asterisk_shutdown
-sig_stop=KILL
-asterisk_shutdown () {
-  %%PREFIX%%/sbin/asterisk -qrx 'stop now'
-  sleep 1
-  return 0
-}
-
 name=asterisk
 rcvar=`set_rcvar`
 
 command=%%PREFIX%%/sbin/asterisk
 
 load_rc_config $name
-
-pidfile=${asterisk_pidfile:-"/var/run/asterisk.pid"}
+pidfile=${asterisk_pidfile:-"/var/run/asterisk/asterisk.pid"}
 
 asterisk_enable=${asterisk_enable:-"NO"}
 
=== ended  ===

>Release-Note:
>Audit-Trail:
>Unformatted: