ports/109174: misc/amanda-clients: all estimate failed

[TAOKA Fumiyoshi]

>Number:         109174
>Category:       ports
>Synopsis:       misc/amanda-clients: all estimate failed
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Feb 14 20:20:03 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     TAOKA Fumiyoshi
>Release:        
>Organization:
>Environment:
>Description:
	amanda-2.5.3p1 fails size estimation.
	As a result no backup is done.

	A patch for the issue is already in amanda source repository.
	http://amanda.cvs.sourceforge.net/amanda/amanda-2/client-src/sendsize.c?view=log#rev1.171.2.5

	Considering the severity of the issue, is there any chance to
	incorporate the patch to amanda ports before the next release
	comes up?

>How-To-Repeat:

You'll see something like below in /tmp/amanda/client/*/sendsize.*.debug.

sendsize[84907]: time 0.343: waiting for any estimate child: 1 running
sendsize[84921]: time 0.344: calculating for amname /, dirname /, spindle 0
sendsize[84921]: time 0.344: getting size via dump for / level 0
sendsize[84921]: time 0.346: calculating for device /dev/aacd0s1a with ufs
sendsize[84921]: time 0.348: running "/sbin/dump 0SSsf 0 1048576 - /dev/aacd0s1a"
sendsize[84921]: time 0.351: running /usr/local/libexec/amanda/killpgrp
sendsize[84921]: time 0.365: dump: tape size must be between 1 and 0
sendsize[84921]: time 0.370: .....
sendsize[84921]: estimate time for / level 0: 0.022
sendsize[84921]: no size line match in /sbin/dump output for "/"
sendsize[84921]: .....
sendsize[84921]: Run /sbin/dump manually to check for errors
sendsize[84921]: time 0.371: asking killpgrp to terminate

>Fix:

Add amanda-server/files/patch-client-src-sendsize.c.
Bump PORTREVISION for amanda-client.

--- amanda-server/files/patch-client-src-sendsize.c	Thu Jan  1 09:00:00 1970
+++ amanda-server/files/patch-client-src-sendsize.c	Thu Feb 15 04:32:22 2007
@@ -0,0 +1,11 @@
+--- client-src/sendsize.c.orig	Thu Feb 15 04:30:19 2007
++++ client-src/sendsize.c	Thu Feb 15 04:31:09 2007
+@@ -1190,7 +1190,7 @@
+ #  endif
+ 	dumpkeys = vstralloc(level_str,
+ 			     PARAM_DUMP_ESTIMATE,
+-			     PARAM_DUMP_ESTIMATE,
++			     PARAM_HONOR_NODUMP,
+ 			     "s", "f", NULL);
+ 
+ #  ifdef HAVE_DUMP_ESTIMATE


--- amanda-client/Makefile.orig	Thu Feb 15 04:51:13 2007
+++ amanda-client/Makefile	Thu Feb 15 04:51:18 2007
@@ -6,7 +6,7 @@
 #
 
 PKGNAMESUFFIX=	-client
-PORTREVISION=	0
+PORTREVISION=	1
 
 COMMENT=	The Advanced Maryland Automatic Network Disk Archiver (client)
 
>Release-Note:
>Audit-Trail:
>Unformatted: