ports/118996: japanese/skkserv crashes always

[KOIE Hidetaka]

>Number:         118996
>Category:       ports
>Synopsis:       japanese/skkserv crashes always
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Dec 24 15:50:03 UTC 2007
>Closed-Date:
>Last-Modified:
>Originator:     KOIE Hidetaka
>Release:        FreeBSD 8.0-CURRENT amd64
>Organization:
>Environment:
FreeBSD guriandgura 8.0-CURRENT FreeBSD 8.0-CURRENT #0: Mon Dec 24 17:01:22 JST 2007 koie at guriandgura:/usr/obj/usr/src/sys/GURIANDGURA amd64
>Description:
skkserv causes SEGV in initializing on amd64.
>How-To-Repeat:
        koie at guriandgura% skkserv
        Segmentation fault (core dumped)
        koie at guriandgura%
>Fix:
Need prototypes in the environment sizeof (int) != sizeof (pointer).

diff -rpub japanese/skkserv/work/skk-9.6/skkserv/skkserv.h japanese/skkserv/work.koie/skk-9.6/skkserv/skkserv.h
--- japanese/skkserv/work/skk-9.6/skkserv/skkserv.h     1997-01-21 04:16:36.000000000 +0900
+++ japanese/skkserv/work.koie/skk-9.6/skkserv/skkserv.h        2007-12-21 22:39:29.671144656 +0900
@@ -37,6 +37,8 @@
 /* Necessary for SunOS 3.x and maybe other old systems */

 #include       <stdio.h>
+#include       <stdlib.h>
+#include       <string.h>

 #include       <sys/types.h>
 #ifdef HAVE_SYS_IOCTL_H
@@ -44,6 +46,7 @@
 #endif
 #include       <sys/socket.h>
 #include       <netinet/in.h>
+#include       <arpa/inet.h>
 #include       <netdb.h>
 #include       <signal.h>
 #include       <errno.h>



The following patch is to suppress a warning.

diff -rpub japanese/skkserv/work/skk-9.6/skkserv/skkserv.c japanese/skkserv/work.koie/skk-9.6/skkserv/skkserv.c
--- japanese/skkserv/work/skk-9.6/skkserv/skkserv.c     1997-01-21 04:16:36.000000000 +0900
+++ japanese/skkserv/work.koie/skk-9.6/skkserv/skkserv.c        2007-12-21 22:40:06.368544948 +0900
@@ -476,7 +476,7 @@ main_loop()

     if (FD_ISSET(initsock, &readfds)) {
       len = sizeof(from);
-      if ((clientsock[nclients ++] = accept(initsock, &from, &len)) < 0) {
+      if ((clientsock[nclients ++] = accept(initsock, (struct sockaddr*)&from, &len)) < 0) {
        err("accept error; something wrong happened with the socket");
       }
       if (nclients >= MAXDTAB - 3 - debug * 2) {

>Release-Note:
>Audit-Trail:
>Unformatted: