ports/118358: math/R update from 2.6.0 to 2.6.1 version
Eric van Gyzen
eric+fbports at vangyzen.net
Wed Dec 5 02:50:02 UTC 2007
The following reply was made to PR ports/118358; it has been noted by GNATS.
From: Eric van Gyzen <eric+fbports at vangyzen.net>
To: bug-followup at FreeBSD.org, Vittorio De Martino <vdemart1 at tin.it>
Cc:
Subject: Re: ports/118358: math/R update from 2.6.0 to 2.6.1 version
Date: Tue, 04 Dec 2007 20:20:32 -0600
Vittorio,
Thanks for your patch. It looks good, but I have some suggestions.
The patch removes several %%FOO%% prefixes from the pkg-plist, such as:
-%%TCLTK%%lib/R/library/tcltk/libs/tcltk.so
+lib/R/library/tcltk/libs/tcltk.so
The %%FOO%% prefixes exist to support the Makefile's OPTIONS; they should
not be removed. See:
http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-options.html
There are a few @dirrm lines that should not change %%DOCSDIR%% to share/doc.
The man pages need not be specified in the pkg-plist; the MAN1 variable in
the Makefile handles them.
Thanks for your work! I'll gladly review a revised patch.
Eric
More information about the freebsd-ports-bugs
mailing list