ports/111217: gnome-speech-0.4.10 fails to compile due to broken #include lines

[Jukka A. Ukkonen]

>Number:         111217
>Category:       ports
>Synopsis:       gnome-speech-0.4.10 fails to compile due to broken #include lines
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Apr 04 06:00:13 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Jukka A. Ukkonen
>Release:        FreeBSD 6.2-STABLE
>Organization:
private
>Environment:
FreeBSD mjolnir 6.2-STABLE FreeBSD 6.2-STABLE #1: Mon Apr  2 08:29:42 EET DST 2007     root at mjolnir:/usr/obj/usr/src/sys/Mjolnir  i386
>Description:
There are a few gnome-speech-0.4.10 source files which try to include
the speak_lib.h header as
#include <speak_lib.h>
This does not succeed though, because /usr/local/include/espeak is not part
of the include path at compile time.


>How-To-Repeat:
Just try to make the gnome-speech-0.4.10 port and you should see
the compilation fail unless you have added something to your
environment to add /usr/local/include/espeak to your include path.

>Fix:
Either fix the broken #include lines as done in the attached patch or
automatically add /usr/local/include/espeak to the include path during
the "make patch" or "make configure" phases.

The preferred method to fixing this kind of problems is fixing the actual
#include lines, because espeak is an independent software package which
should keep its own headers under its own special directory anyhow.


Patch attached with submission follows:

--- ./drivers/espeak/espeaksynthesisdriver.h.old	Wed Apr  4 08:25:05 2007
+++ ./drivers/espeak/espeaksynthesisdriver.h	Wed Apr  4 08:34:05 2007
@@ -31,7 +31,7 @@
 #include <bonobo/bonobo-object.h>
 #include <glib/gthread.h>
 #include <gnome-speech/gnome-speech.h>
-#include <speak_lib.h>
+#include <espeak/speak_lib.h>
 #include "espeakspeaker.h"
 
 #define ESPEAK_SYNTHESIS_DRIVER_TYPE        (espeak_synthesis_driver_get_type ())
--- ./drivers/espeak/espeakspeaker.h.old	Wed Apr  4 08:26:06 2007
+++ ./drivers/espeak/espeakspeaker.h	Wed Apr  4 08:34:06 2007
@@ -35,7 +35,7 @@
 
 #include <bonobo/bonobo-object.h>
 #include <glib/gthread.h>
-#include <speak_lib.h>
+#include <espeak/speak_lib.h>
 #include <gnome-speech/gnome-speech.h>
 
 
--- ./drivers/espeak/espeakspeaker.c.old	Wed Apr  4 08:26:54 2007
+++ ./drivers/espeak/espeakspeaker.c	Wed Apr  4 08:34:06 2007
@@ -28,7 +28,7 @@
 #include <libbonobo.h>
 #include <glib/gmain.h>
 #include <gnome-speech/gnome-speech.h>
-#include <speak_lib.h>
+#include <espeak/speak_lib.h>
 #include "espeaksynthesisdriver.h"
 #include "espeakspeaker.h"
 
--- ./drivers/espeak/espeaksynthesisdriver.c.old	Wed Apr  4 08:23:21 2007
+++ ./drivers/espeak/espeaksynthesisdriver.c	Wed Apr  4 08:34:06 2007
@@ -28,7 +28,7 @@
 #include <stdlib.h>
 #include <libbonobo.h>
 #include <glib/gmain.h>
-#include <speak_lib.h>
+#include <espeak/speak_lib.h>
 #include <gnome-speech/gnome-speech.h>
 #include "espeaksynthesisdriver.h"
 #include "espeakspeaker.h"

>Release-Note:
>Audit-Trail:
>Unformatted: