ports/104887: databases/grass-i18n installs files with invalid ownership

[TAOKA Fumiyoshi]

>Number:         104887
>Category:       ports
>Synopsis:       databases/grass-i18n installs files with invalid ownership
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Oct 28 20:00:40 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     TAOKA Fumiyoshi
>Release:        
>Organization:
>Environment:
>Description:

Installing the port with Tcl/Tk support, you'll see some files have
owner 1004 and group 513, which may be assigned to someone.
I think files installed by ports should have normally owner 0 (root)
and group 0 (wheel).

These files are from an extra tar ball, FILES_TKI18N.
As being a tar ball unpacked by root, permissions in the archive are
preserved, do-extract target does chmod -R ug-s and chown -R 0:0
explicitly.  FILES_TKI18N is, however, unpacked by not do-extract
but post-extract target and not chowned.

The port has two extra tar balls, FILES_TKI18N and FILES_FONTS.
and they are both unpacked by post-extract target.
They should be treated as do-extract does
(though FILES_FONTS is currently not an issue). 


>How-To-Repeat:

# cd /usr/ports/databases/grass-i18n
# make WITH_TCLTK=yes install
# ls -ln /usr/local/grass/scripts
total 330
-rwxr-xr-x  1 0     0     5262 Jun 13 22:11 3d.view.sh
-rwxr-xr-x  1 0     0      711 Jun 13 22:11 blend.sh
-rwxr-xr-x  1 0     0     3475 Jun 13 22:11 bug.report.sh
-rwxr-xr-x  1 0     0     1960 Jun 13 22:11 create_fifos.sh
-rwxr-xr-x  1 0     0    22949 Jun 13 22:04 d.dm
-rwxr-xr-x  1 1004  513  23260 Dec  9  2003 d.dm-i18n

(snip)

# ls -lnR /usr/local/grass/tcltkgrass

>Fix:

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/databases/grass-i18n/Makefile,v
retrieving revision 1.36
diff -u -r1.36 Makefile
--- Makefile	15 Nov 2005 06:48:19 -0000	1.36
+++ Makefile	28 Oct 2006 19:21:17 -0000
@@ -6,6 +6,7 @@
 
 PORTNAME=	grass-i18n
 PORTVERSION=	5.0.3
+PORTREVISION=	1
 CATEGORIES=	databases
 MASTER_SITES=	http://www.grass-japan.org/FOSS4G/GRASS/:grass \
 		http://www.grass-japan.org/FOSS4G/ipafonts/:ipafonts
@@ -103,6 +104,10 @@
 	${MV} ${WRKSRC}/src/tcltkgrass/${D} ${WRKSRC}/src/tcltkgrass/${D}.orig
 	${MV} ${WRKDIR}/tcltkgrass-i18n/tcltkgrass-i18n/${D} ${WRKSRC}/src/tcltkgrass/${D}
 .endfor
+	@if [ `${ID} -u` = 0 ]; then \
+		${CHMOD} -R ug-s ${WRKDIR}; \
+		${CHOWN} -R 0:0 ${WRKDIR}; \
+	fi
 
 post-patch:
 	${CP} ${WRKSRC}/configure.in ${WRKSRC}/configure.in.orig
>Release-Note:
>Audit-Trail:
>Unformatted: