ports/105488: [patch] security/ipsec-tools: NAT-T support silently ignored if header file unpatched

[Bjoern A. Zeeb]

The following reply was made to PR ports/105488; it has been noted by GNATS.

From: "Bjoern A. Zeeb" <bzeeb-lists at lists.zabbadoz.net>
To: VANHULLEBUS Yvan <yvan.vanhullebus at netasq.com>
Cc: bug-followup at FreeBSD.org
Subject: Re: ports/105488: [patch] security/ipsec-tools: NAT-T support silently
 ignored if header file unpatched
Date: Wed, 15 Nov 2006 21:27:52 +0000 (UTC)

 On Wed, 15 Nov 2006, VANHULLEBUS Yvan wrote:
 
 > People who just don't know what is NAT-T won't care about it (and will
 > automagically have it when the patch will be included in FreeBSD's
 > CVS), and people who want it should have read the warning about
 > needing a kernel patch.
 
 People who won't care don't need it and would leave it to default
 which is off anyway so that case does not matter.
 
 People who want it do not want it to be left out when they have to
 explicitly to turn it on. By turning it on they say "I want this"
 but do not say "I want this maybe". If they do a make package and
 deploy it and it turns out to not be in it might take them hours to
 figure out what went wrong.
 
 It's a YES/NO thing and no MAYBE. If you want a MAYBE do it for
 the default NO case but that will not permit people to leave it out
 when their system would have the header files that support it.
 
 So if you want a MAYBE do not provide an option but that will not
 allow the poeple to chose - that's what the options from make config
 are about.
 
 It's basically like a light switch: you can turn it on and there
 should be light (or something will be wrong and you want to know about
 that) or turn it off and light should be off (and not coincidentally
 stay on).
 
 -- 
 Bjoern A. Zeeb				bzeeb at Zabbadoz dot NeT