ports/97700: [PATCH] games/spicetrade: Update to bsd.java.mk 2.0 and other improvements

[Herve Quiroz]

>Number:         97700
>Category:       ports
>Synopsis:       [PATCH] games/spicetrade: Update to bsd.java.mk 2.0 and other improvements
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue May 23 18:20:24 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Herve Quiroz
>Release:        FreeBSD 6.1-RELEASE i386
>Organization:
>Environment:
System: FreeBSD arabica.esil.univ-mrs.fr 6.1-RELEASE FreeBSD 6.1-RELEASE #0: Tue May  9 17:19:22 CEST
>Description:

- Update to bsd.java.mk 2.0
- Set JAVA_VERSION in launcher shell script
- Use absolute path for javavmwrapper in launcher shell script
- Add $FreeBSD$ tag
- Unquote NO_PACKAGE [1]

Reported by:	portlint [1]

NOTE: is there a reason why the port uses USE_X_PREFIX? The Porter's Handbook
encourages the use of DATADIR=${JAVASHAREDIR}/${PORTNAME} for applications
which only install machine-independent java-related files:

http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/using-java.html#JAVA-BEST-PRACTICES

Port maintainer (daniel at roe.ch) is cc'd.

Generated with FreeBSD Port Tools 0.77
>How-To-Repeat:
>Fix:

--- spicetrade-1.2.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/games/spicetrade/Makefile,v
retrieving revision 1.2
diff -u -u -r1.2 Makefile
--- Makefile	11 Dec 2005 22:46:28 -0000	1.2
+++ Makefile	23 May 2006 18:15:20 -0000
@@ -17,9 +17,10 @@
 MAINTAINER=	daniel at roe.ch
 COMMENT=	Colourful 14th century Arab spice trading game
 
-NO_PACKAGE=	"Package will be 186MB, set FORCE_PACKAGE if you really want to build it"
+NO_PACKAGE=	Package will be 186MB, set FORCE_PACKAGE if you really want to build it
 
-USE_JAVA=	1.4+
+USE_JAVA=	yes
+JAVA_VERSION=	1.4+
 USE_X_PREFIX=	yes
 NO_BUILD=	yes
 
Index: files/spicetrade.in
===================================================================
RCS file: /home/ncvs/ports/games/spicetrade/files/spicetrade.in,v
retrieving revision 1.1
diff -u -u -r1.1 spicetrade.in
--- files/spicetrade.in	11 Sep 2005 02:24:26 -0000	1.1
+++ files/spicetrade.in	23 May 2006 18:15:20 -0000
@@ -1,2 +1,6 @@
 #!/bin/sh
-exec java -jar %%JARFILE%% "$@"
+#
+# $FreeBSD$
+
+JAVA_VERSION="%%JAVA_VERSION%%" \
+	exec "%%LOCALBASE%%/bin/java" -jar "%%JARFILE%%" "$@"
--- spicetrade-1.2.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted: