ports/86315: vncviewer in net/tightvnc crashes on local machine desktop switch

[Li-Lun Wang (Leland Wang)]

>Number:         86315
>Category:       ports
>Synopsis:       vncviewer in net/tightvnc crashes on local machine desktop switch
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Sep 19 00:40:13 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Li-Lun Wang (Leland Wang)
>Release:        FreeBSD 6.0-BETA5 i386
>Organization:
>Environment:
System: FreeBSD ll-X31 6.0-BETA5 FreeBSD 6.0-BETA5 #7: Sun Sep 18 17:07:53 CDT 2005     root at ll-X31:/usr/obj/usr/src/sys/X31  i386


	
>Description:
Desktop switch on local machine causes the vncviewer in tightvnc to crash with

CleanupXErrorHandler called
ShmCleanup called
X Error of failed request: BadMatch (invalid parameter
attributes)
Major opcode of failed request: 42 (X_SetInputFocus)
Serial number of failed request: 5078
Current serial number in output stream: 5078

Ref: http://sourceforge.net/tracker/index.php?func=detail&aid=1202622&group_id=14067&atid=114067
	
>How-To-Repeat:
Use the vncviewer in net/tightvnc to connect to a vncserver. While focusing
on vncviewer, switch to another virtual desktop with keyboard.
	
>Fix:
diff -urN tightvnc.orig/Makefile tightvnc/Makefile
--- tightvnc.orig/Makefile	Sat May 28 17:02:40 2005
+++ tightvnc/Makefile	Sun Sep 18 19:22:01 2005
@@ -8,6 +8,7 @@
 
 PORTNAME=	tightvnc
 PORTVERSION=	1.2.9
+PORTREVISION=	1
 CATEGORIES=	net
 MASTER_SITES=	${MASTER_SITE_SOURCEFORGE}
 MASTER_SITE_SUBDIR=	vnc-tight
diff -urN tightvnc.orig/files/patch-vncviewer::desktop.c tightvnc/files/patch-vncviewer::desktop.c
--- tightvnc.orig/files/patch-vncviewer::desktop.c	Wed Dec 31 18:00:00 1969
+++ tightvnc/files/patch-vncviewer::desktop.c	Sun Sep 18 19:21:17 2005
@@ -0,0 +1,14 @@
+--- vncviewer/desktop.c.orig	Thu Jul 31 00:01:00 2003
++++ vncviewer/desktop.c	Sun Sep 18 19:20:06 2005
+@@ -180,8 +180,9 @@
+     break;
+ 
+   case FocusIn:
+-      XSetInputFocus(dpy, XtWindowOfObject(desktop), RevertToPointerRoot,
+-		     CurrentTime);
++      /** XSetInputFocus(dpy, XtWindowOfObject(desktop), RevertToPointerRoot,
++		     CurrentTime); **/
++      XSetInputFocus(dpy, PointerRoot, RevertToPointerRoot, CurrentTime);
+     break;
+ 
+   case FocusOut:

	


>Release-Note:
>Audit-Trail:
>Unformatted: