ports/88941: Suggested updates of mail/cclient Makefile

[Mats Dufberg]

>Number:         88941
>Category:       ports
>Synopsis:       Suggested updates of mail/cclient Makefile
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Nov 13 18:50:21 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Mats Dufberg
>Release:        N/A
>Organization:
private
>Environment:
N/A   
>Description:
1. By default the cclient uses the old-fashioned unix type of mail folder 
format. Included in cclient there is an alternative, MBX format, which 
is recommended by the Pine development team as a more effecient format, which 
it really is. The mail/cclient port does not offer any convinient way of 
using that as the default folder format. I suggest that there is an options 
to patch the source to get MBX as the default mailbox format.

2. The mail/cclient port has serveral options. Today they are handled in 
the old-fashioned way which requires that the user includes those as options 
on the command line when upgrading, which makes upgrades more cumbersome. 
I suggets that the mail/cclient port uses settings with OPTIONS to achieve 
a simpler handling.



        
>How-To-Repeat:
N/A
>Fix:
The patch below will update the mail/cclient Makefile to support the two 
suggested changes. I have locally tested the patch, and found no problems 
with it.


--- Makefile.orig       Sat Oct  8 05:14:27 2005
+++ Makefile    Sun Nov 13 13:40:29 2005
@@ -20,6 +20,13 @@
 MAINTAINER=    anders at FreeBSD.org
 COMMENT=       Mark Crispin's C-client mail access routines
 
+OPTIONS=        SSL "Compile with SSL support" on \
+                SSL_AND_PLAINTEXT "Accept plain text passwords with SSL" off \
+                IPV6 "Support IPv6" on \
+                MBX_DEFAULT "Use MBX as default mailbox format" off
+
+.include <bsd.port.pre.mk>
+
 INSTALLS_SHLIB=        yes
 ALL_TARGET=    bsf
 .if defined(WITHOUT_SSL)
@@ -42,8 +49,6 @@
 MAKE_ENV=      SHLIBNAME=${SHLIBNAME} SHLIBBASE=${SHLIBBASE}
 PLIST_SUB=     SHLIBNAME=${SHLIBNAME} SHLIBBASE=${SHLIBBASE}
 
-.include <bsd.port.pre.mk>
-
 .if ${PORTOBJFORMAT} == "aout"
 SHLIBNAME=     lib${SHLIBBASE}.so.${SHLIBMAJ}.0
 .endif
@@ -58,6 +63,16 @@
        @${REINPLACE_CMD} -e "s|^IP=4|IP=6|" ${WRKSRC}/Makefile \
                ${WRKSRC}/src/osdep/unix/Makefile
 .endif
+# Do this here because other patches also modifies this file
+.if defined(WITH_MBX_DEFAULT)
+       @${CP} ${WRKSRC}/src/osdep/unix/Makefile \
+               ${WRKSRC}/src/osdep/unix/Makefile.presed2
+       @${SED} -e 's:^CREATEPROTO=unixproto:CREATEPROTO=mbxproto:' \
+               ${WRKSRC}/src/osdep/unix/Makefile.presed2 > \
+               ${WRKSRC}/src/osdep/unix/Makefile
+.endif  
+#
+
 
 post-configure:
        @${ECHO_MSG} ">> The c-client shared library will be named ${SHLIBNAME}"

>Release-Note:
>Audit-Trail:
>Unformatted: