ports/88754: Make USE_REINPLACE noop

Pav Lucistnik pav at FreeBSD.org
Wed Nov 9 22:00:20 UTC 2005


>Number:         88754
>Category:       ports
>Synopsis:       Make USE_REINPLACE noop
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Nov 09 22:00:18 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Pav Lucistnik
>Release:        FreeBSD 6.0-RC1 amd64
>Organization:
>Environment:
System: FreeBSD ikaros.oook.cz 6.0-RC1 FreeBSD 6.0-RC1 #0: Tue Nov 1 15:16:08 CET 2005 root at ikaros.oook.cz:/usr/obj/usr/src/sys/GENERIC amd64


	
>Description:
In last batch of bsd.port.mk updates, old REINPLACE_CMD handling was removed.
Now the whole code consists of setting two make variables.

Because it no longer includes any external dependencies, I do propose to have
REINPLACE_CMD defined all the time, and that we remove USE_REINPLACE.

After this is committed, we can start removing USE_REINPLACE from individual
ports, slowly, over time.
>How-To-Repeat:
	
>Fix:

Index: bsd.port.mk
===================================================================
RCS file: /home/pcvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.518
diff -a -u -r1.518 bsd.port.mk
--- bsd.port.mk	8 Nov 2005 09:02:51 -0000	1.518
+++ bsd.port.mk	9 Nov 2005 21:55:17 -0000
@@ -1715,7 +1715,6 @@
 
 .if defined(PERL_CONFIGURE)
 USE_PERL5=	yes
-USE_REINPLACE=yes
 .endif
 
 .if ${PERL_LEVEL} >= 500600
@@ -1812,11 +1811,9 @@
 RUN_DEPENDS+=	gs:${PORTSDIR}/${GHOSTSCRIPT_PORT}
 .endif
 
-# Special macro for doing in-place file editing using regexps
-.if defined(USE_REINPLACE)
+# Macro for doing in-place file editing using regexps
 REINPLACE_ARGS?=	-i.bak
 REINPLACE_CMD?=	${SED} ${REINPLACE_ARGS}
-.endif
 
 # Names of cookies used to skip already completed stages
 EXTRACT_COOKIE?=	${WRKDIR}/.extract_done.${PKGNAME}.${PREFIX:S/\//_/g}
>Release-Note:
>Audit-Trail:
>Unformatted:



More information about the freebsd-ports-bugs mailing list