ports/81267: [MAINTAINER] security/openvpn: plug socket (file descriptor) leak

[Matthias Andree]

>Number:         81267
>Category:       ports
>Synopsis:       [MAINTAINER] security/openvpn: plug socket (file descriptor) leak
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Thu May 19 15:50:06 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Matthias Andree
>Release:        FreeBSD 5.4-STABLE i386
>Organization:
>Environment:
System: FreeBSD merlin.emma.line.org 5.4-STABLE FreeBSD 5.4-STABLE #29: Thu May  5 11:41:16 CEST
>Description:
Plug socket (file descriptor) leak.

Submitted by: Jaroslav Klaus <J.Klaus at sh.cvut.cz>

Added file(s):
- files/patch-route.c

Generated with FreeBSD Port Tools 0.63
>How-To-Repeat:
>Fix:

--- openvpn-2.0_1.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/security/openvpn/Makefile /root/ports/security/openvpn/Makefile
--- /usr/ports/security/openvpn/Makefile	Sat Apr 23 11:29:38 2005
+++ /root/ports/security/openvpn/Makefile	Thu May 19 17:18:56 2005
@@ -7,6 +7,7 @@
 
 PORTNAME=	openvpn
 DISTVERSION=	2.0
+PORTREVISION=	1
 CATEGORIES=	security
 MASTER_SITES=	http://openvpn.net/release/
 
diff -ruN --exclude=CVS /usr/ports/security/openvpn/files/patch-route.c /root/ports/security/openvpn/files/patch-route.c
--- /usr/ports/security/openvpn/files/patch-route.c	Thu Jan  1 01:00:00 1970
+++ /root/ports/security/openvpn/files/patch-route.c	Thu May 19 17:14:10 2005
@@ -0,0 +1,50 @@
+--- route.c.orig	Mon Apr 11 05:43:56 2005
++++ route.c	Mon May 16 21:13:41 2005
+@@ -1380,6 +1380,7 @@
+     {
+       warn("writing to routing socket");
+       gc_free (&gc);
++      close(s);
+       return false;
+     }
+ 
+@@ -1387,6 +1388,7 @@
+     l = read(s, (char *)&m_rtmsg, sizeof(m_rtmsg));
+   } while (l > 0 && (rtm.rtm_seq != seq || rtm.rtm_pid != pid));
+                         
++  close(s);
+ 
+   rtm_aux = &rtm;
+ 
+@@ -1535,6 +1537,7 @@
+     {
+       msg (M_WARN, "ROUTE: problem writing to routing socket");
+       gc_free (&gc);
++      close(s);
+       return false;
+     }
+ 
+@@ -1542,6 +1545,7 @@
+     l = read(s, (char *)&m_rtmsg, sizeof(m_rtmsg));
+   } while (l > 0 && (rtm.rtm_seq != seq || rtm.rtm_pid != pid));
+                         
++  close(s);
+ 
+   rtm_aux = &rtm;
+ 
+@@ -1690,6 +1694,7 @@
+     {
+       warn("writing to routing socket");
+       gc_free (&gc);
++      close(s);
+       return false;
+     }
+ 
+@@ -1697,6 +1702,7 @@
+     l = read(s, (char *)&m_rtmsg, sizeof(m_rtmsg));
+   } while (l > 0 && (rtm.rtm_seq != seq || rtm.rtm_pid != pid));
+                         
++  close(s);
+ 
+   rtm_aux = &rtm;
+ 
--- openvpn-2.0_1.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted: