ports/82826: Tcl 8.4.10 build is broken.

[Michael Edenfield]

>Number:         82826
>Category:       ports
>Synopsis:       Tcl 8.4.10 build is broken.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jun 30 15:20:17 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Michael Edenfield
>Release:        FreeBSD 5.1-CURRENT i386
>Organization:
>Environment:
System: FreeBSD wombat.localnet 5.1-CURRENT FreeBSD 5.1-CURRENT #7: Sun Aug 24 21:35:57 EDT 2003 root at wombat.localnet:/usr/obj/usr/src/sys/ATHLON i386

>Description:

There is a known problem building Tcl v8.4.10 with GCC 3.x.  The problem is apparently hidden by a bug in gcc4.0.  This problem is resolved in the CVS version of Tcl but the fix hasn't made it into a release version yet.

>How-To-Repeat:
>Fix:

Add the following patch file to lang/tcl84/files:

--- tclUnixNotfy.c~     Wed Jun  1 15:12:21 2005
+++ tclUnixNotfy.c      Thu Jun  9 15:31:18 2005
@@ -294,7 +294,7 @@
   close(triggerPipe);
 
        Tcl_ConditionWait(&notifierCV, &notifierMutex, NULL);
-       result = Tcl_JoinThread(notifierThread);
+       result = Tcl_JoinThread(notifierThread, NULL);
        if (result) {
            Tcl_Panic("Tcl_FinalizeNotifier: unable to join notifier
            thread");
            }
>Release-Note:
>Audit-Trail:
>Unformatted: