ports/82524: httplog fails to recognise current version of zlib

[Andrew McNaughton]

>Number:         82524
>Category:       ports
>Synopsis:       httplog fails to recognise current version of zlib
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jun 22 13:00:34 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Andrew McNaughton
>Release:        FreeBSD 4.11-RELEASE-p9 i386
>Organization:
Scoop Media Ltd
>Environment:
System: FreeBSD a2.scoop.co.nz 4.11-RELEASE-p9 FreeBSD 4.11-RELEASE-p9 #1: Mon May 16 14:40:36 NZST 2005 andrew at a2.scoop.co.nz:/usr/obj/usr/src-4.10/sys/wal i386


>Description:

The patch for configure allowed for a past upgrade of zlib by checking for version 1.1.3 or 1.1.4 rather than just for 1.1.3.

zlib 1.1.4 is now outdated, so the port simply fails to use zlib.  I've successfully fixed this on my own system by adding another version to check for.  Really the check should just be for version >= 1.1.3, but my shell scripting skills are limited (thanks to perl), and I'm not sure how to do a reasonable version comparison.

>How-To-Repeat:
>Fix:

My solution (inadequate, as noted) was to replace patch-configure with the following.

This works for the time being, but will break again when zlib is next updated.


--- configure.orig      Tue Dec 16 10:40:16 2003
+++ configure   Tue Dec 16 10:41:45 2003
@@ -140,7 +140,7 @@
 EOF
        $CC -o ./dummy ./dummy.c -lz 1>/dev/null 2>&1
        if [ $? -eq 0 ]; then
-               if [ `./dummy` = "1.1.3" ]; then
+               if [ `./dummy` = "1.1.3" -o `./dummy` = "1.1.4" -o `./dummy` = "1.2.1" ]; then
                        use_zlib=yes
                        LDFLAGS="$LDFLAGS -lz"
                        echo "Checking zlib version: `./dummy` found."




>Release-Note:
>Audit-Trail:
>Unformatted: