ports/77557: [patch] remove duplicate USE_XLIB handling from bsd.port.mk
Pav Lucistnik
pav at FreeBSD.org
Tue Feb 15 13:50:25 UTC 2005
>Number: 77557
>Category: ports
>Synopsis: [patch] remove duplicate USE_XLIB handling from bsd.port.mk
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Tue Feb 15 13:50:23 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator: Pav Lucistnik
>Release: FreeBSD 5.3-STABLE i386
>Organization:
>Environment:
System: FreeBSD hood.oook.cz 5.3-STABLE FreeBSD 5.3-STABLE #0: Mon Jan 3 19:26:07 CET 2005 root at hood.oook.cz:/usr/obj/usr/src/sys/PAV i386
>Description:
girgen in rev. 1.506 of bsd.port.mk added duplicate copy of USE_XLIB handling
code. This looks like an obvious copy&past-o to me, as exactly same segment
is now repeatet just few lines below it. And, the change have no relation
to PostgreSQL which girgen's commit was addressing.
Krion's take:
<krion> Subject: these portmgr bitches b0rked the sexiness factor 8
>How-To-Repeat:
>Fix:
Revert a part of 1.506:
Index: bsd.port.mk
===================================================================
RCS file: /home/pcvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.509
diff -a -u -r1.509 bsd.port.mk
--- bsd.port.mk 9 Feb 2005 09:07:37 -0000 1.509
+++ bsd.port.mk 15 Feb 2005 13:37:14 -0000
@@ -1737,14 +1737,6 @@
CONFIGURE_ENV+= CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}"
.endif # USE_PGSQL
-.if defined(USE_XLIB)
-LIB_DEPENDS+= X11.6:${X_LIBRARIES_PORT}
-# Add explicit X options to avoid problems with false positives in configure
-.if defined(GNU_CONFIGURE)
-CONFIGURE_ARGS+=--x-libraries=${X11BASE}/lib --x-includes=${X11BASE}/include
-.endif
-.endif
-
# XXX: (not yet): .if defined(USE_AUTOTOOLS)
.include "${PORTSDIR}/Mk/bsd.autotools.mk"
# XXX: (not yet): .endif
>Release-Note:
>Audit-Trail:
>Unformatted:
More information about the freebsd-ports-bugs
mailing list