ports/84526: [PATCH] audio/moc: missing dependency (audio/libid3tag) for MP3 support

[Nicola Vitale]

>Number:         84526
>Category:       ports
>Synopsis:       [PATCH] audio/moc: missing dependency (audio/libid3tag) for MP3 support
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Aug 03 17:10:10 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Nicola Vitale
>Release:        FreeBSD 5.4-RELEASE-p4 i386
>Organization:
>Environment:

System: FreeBSD stellina.domo.sva 5.4-RELEASE-p4 FreeBSD 5.4-RELEASE-p4 #1: Sat Jul 16 15:18:36 CEST 2005

>Description:

It seems that moc requires libid3tag to build with MP3 support,
but such library is not in LIB_DEPENDS.
 
Port maintainer (rzinkov at gmail.com) is cc'd.

Generated with FreeBSD Port Tools 0.63

>How-To-Repeat:

# cd /usr/ports/audio/moc; make install
[...]
checking for id3_file_open in -lid3tag... no
configure: error: You need libid3tag to play mp3, check the README file.
===>  Script "configure" failed unexpectedly.
Please report the problem to rzinkov at gmail.com [maintainer] and attach the
"/mnt/ufs-ad1s1e/ports/audio/moc/work/moc-2.3.0/config.log" including the
output of the failure of your make command. Also, it might be a good idea to
provide an overview of all packages installed on your system (e.g. an `ls
/var/db/pkg`).
*** Error code 1

Stop in /mnt/ufs-ad1s1e/ports/audio/moc.

>Fix:

--- moc-2.3.0_1.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/audio/moc/Makefile /mnt/ufs-ad1s1e/ports/audio/moc.my/Makefile
--- /usr/ports/audio/moc/Makefile	Tue Aug  2 11:46:19 2005
+++ /mnt/ufs-ad1s1e/ports/audio/moc.my/Makefile	Wed Aug  3 18:39:44 2005
@@ -48,7 +48,8 @@
 .endif
 
 .if defined(WITH_MP3)
-LIB_DEPENDS+=	mad.2:${PORTSDIR}/audio/mad
+LIB_DEPENDS+=	mad.2:${PORTSDIR}/audio/mad \
+		id3tag.2:${PORTSDIR}/audio/libid3tag
 PLIST_FILES+=	lib/moc/decoder_plugins/libmp3_decoder.so
 .else
 CONFIGURE_ARGS+=	--without-mp3
--- moc-2.3.0_1.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted: