ports/79826: multimedia/transcode builds without optimization if multimedia/linux-divx4linux is installed

[Jonathan Lennox]

>Number:         79826
>Category:       ports
>Synopsis:       multimedia/transcode builds without optimization if multimedia/linux-divx4linux is installed
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Apr 12 15:10:30 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Jonathan Lennox
>Release:        FreeBSD 5.3-RELEASE-p2 i386
>Organization:
Columbia University
>Environment:
System: FreeBSD cnr.cs.columbia.edu 5.3-RELEASE-p2 FreeBSD 5.3-RELEASE-p2 #9: Sat Dec 4 12:36:03 EST 2004 lennox at cnr.cs.columbia.edu:/usr/obj/usr/src/sys/CNR i386


	
>Description:

Due to a bug in the port Makefile, if the port multimedia/linux-divx4linux is
installed, the build of the port multimedia/transcode discards the system
CFLAGS, so transcode is built without any optimization flags.

>How-To-Repeat:
# portinstall multimedia/linux-divx4linux
# cd /usr/ports/multimedia/transcode; make

Observe the arguments to cc, in particular the lack of any -O options.

>Fix:

The following patch fixes it.  This fix might imply that a PORTREVISION
bump is in order; I'm not sure of what policy is on that.

Alternately, as a workaround, uninstall multimedia/linux-divx4linux before
building transcode.

--- multimedia/transcode/Makefile.orig	Tue Apr 12 10:54:59 2005
+++ multimedia/transcode/Makefile	Tue Apr 12 10:55:47 2005
@@ -261,7 +261,7 @@
 
 .if defined(WITH_DIVX5)
 BUILD_DEPENDS+=	${LINUXBASE}/usr/lib/libdivxdecore.so:${PORTSDIR}/multimedia/linux-divx4linux
-CONFIGURE_ENV+=	CFLAGS="-I${LINUXBASE}/usr/include/divx" CPPFLAGS="-I${LINUXBASE}/usr/include/divx"
+CONFIGURE_ENV+=	CFLAGS="-I${LINUXBASE}/usr/include/divx" CPPFLAGS="-I${LINUXBASE}/usr/include/divx ${CFLAGS}"
 .else
 .endif
 



>Release-Note:
>Audit-Trail:
>Unformatted: