ports/67403: games/kdegames3 installs some files with invalid uid and gid

[Taoka Fumiyoshi]

>Number:         67403
>Category:       ports
>Synopsis:       games/kdegames3 installs some files with invalid uid and gid
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun May 30 17:30:22 PDT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Taoka Fumiyoshi
>Release:        FreeBSD 5.2-CURRENT i386
>Organization:
>Environment:
>Description:

	games/kdegames3 installs some file with invalid uid and gid.
	They are untared directly into
	/usr/local/share/apps/kgoldrunner/system/levels.
	However they are immediately chowned to root.root, it fails.

	FreeBSD's chown currently uses not `.' but ':' as uid:gid
	separator and their group should be not `root' but `wheel'.

	The failure is hardly noticed during `make install' because
	its output goes to /dev/null and its return code is override
	by true in a makefile.

>How-To-Repeat:
	
# make install
# ls -l /usr/local/share/apps/kgoldrunner/system/levels
total 352
-rw-r--r--  1 500  100   621 Dec  9 20:17 fred
-rw-r--r--  1 500  100   561 Jan 24  2002 level000.grl
-rw-r--r--  1 500  100   561 Jan 24  2002 level001.grl
-rw-r--r--  1 500  100   561 Jan 24  2002 level002.grl
-rw-r--r--  1 500  100   561 Jan 24  2002 level003.grl
-rw-r--r--  1 500  100   561 Jan 24  2002 level004.grl
-rw-r--r--  1 500  100   561 Jan 24  2002 level005.grl
(snip)

>Fix:

diff -uN files.orig/patch-aa files/patch-aa
--- files.orig/patch-aa	Thu Jan  1 09:00:00 1970
+++ files/patch-aa	Mon May 31 08:27:14 2004
@@ -0,0 +1,9 @@
+--- kgoldrunner/gamedata/Makefile.am Mon.orig May 31 07:55:56 2004
++++ kgoldrunner/gamedata/Makefile.am Mon May 31 07:56:16 2004
+@@ -8,6 +8,6 @@
+ 	$(mkinstalldirs) $(DESTDIR)$(gamedatadir)
+ 	pwd=`cd $(srcdir) && pwd` ;\
+ 	cd $(DESTDIR)$(gamedatadir) && tar -xf $$pwd/levels.tar ;\
+-	chown -R root.root levels 2> /dev/null || true ;\
++	chown -R root:wheel levels 2> /dev/null || true ;\
+ 	chmod 644 levels/* 2> /dev/null || true
diff -uN files.orig/patch-ab files/patch-ab
--- files.orig/patch-ab	Thu Jan  1 09:00:00 1970
+++ files/patch-ab	Mon May 31 08:27:25 2004
@@ -0,0 +1,11 @@
+--- kgoldrunner/gamedata/Makefile.in.orig	Mon May 31 08:12:02 2004
++++ kgoldrunner/gamedata/Makefile.in	Mon May 31 08:13:28 2004
+@@ -561,7 +561,7 @@
+ 	$(mkinstalldirs) $(DESTDIR)$(gamedatadir)
+ 	pwd=`cd $(srcdir) && pwd` ;\
+ 	cd $(DESTDIR)$(gamedatadir) && tar -xf $$pwd/levels.tar ;\
+-	chown -R root.root levels 2> /dev/null || true ;\
++	chown -R root:wheel levels 2> /dev/null || true ;\
+ 	chmod 644 levels/* 2> /dev/null || true 
+ # Tell versions [3.59,3.63) of GNU make to not export all variables.
+ # Otherwise a system limit (for SysV at least) may be exceeded.
>Release-Note:
>Audit-Trail:
>Unformatted: