ports/66743: bsd.port.mk: ALL-DEPENDS-LIST doesn't recurse into all dependend ports

[Oliver Eikemeier]

>Number:         66743
>Category:       ports
>Synopsis:       bsd.port.mk: ALL-DEPENDS-LIST doesn't recurse into all dependend ports
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon May 17 07:00:36 PDT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Oliver Eikemeier
>Release:        FreeBSD 4.10-STABLE i386
>Organization:
Fillmore Labs - http://www.fillmore-labs.com
>Environment:
System: FreeBSD nuuk.fillmore-labs.com 4.10-STABLE

>Description:

ALL-DEPENDS-LIST has been changed to call `make run-depends-list' instead of 
`make all-depends-list', eliminating its recurisive behaviour.
  <http://www.freebsd.org/cgi/cvsweb.cgi/ports/Mk/bsd.port.mk.diff?r1=1.487&r2=1.488>

  This bug affects bsd.port.mk of 4.10-RELEASE.

The change results in third-level dependencies are being missed in all targets
that use this macro:

- all-depends-list
- clean-depends
- deinstall-depends
- fetch-recursive
- fetch-recursive-list
- checksum-recursive
- package-recursive

and all targets that use them, like clean.

package-depends-list is not affected, since it uses its own recursion.

>How-To-Repeat:

cd /usr/ports/mail/p5-Mail-SpamAssassin; make clean

The following dependency chain is broken:
  mail/p5-Mail-SpamAssassin -> dns/p5-Net-DNS -> security/p5-Digest-HMAC -/-> security/p5-Digest-MD5

>Fix:

Restore the old behaviour or make RUN-DEPENDS-LIST recursive too. Before 
switching to run-depends it should be considered that `fetch-recursive' is 
actually expected to fetch *all* needed distfiles, not only the ones the
port run-depends on.

>Release-Note:
>Audit-Trail:
>Unformatted: