ports/62398: [PATCH] devel/p5-AppConfig: update to 1.56, take maintainership

[Erwin Lansing]

The following reply was made to PR ports/62398; it has been noted by GNATS.

From: Erwin Lansing <erwin at lansing.dk>
To: Mathieu Arnold <mat at FreeBSD.org>
Cc: Lars Thegler <lars at thegler.dk>, freebsd-ports-bugs at FreeBSD.org,
	FreeBSD-gnats-submit at FreeBSD.org
Subject: Re: ports/62398: [PATCH] devel/p5-AppConfig: update to 1.56, take maintainership
Date: Fri, 6 Feb 2004 16:14:28 +0100

 --W/nzBZO5zC0uMSeA
 Content-Type: text/plain; charset=iso-8859-1
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 On Fri, Feb 06, 2004 at 03:47:04PM +0100, Mathieu Arnold wrote:
 > +-le 06/02/2004 14:53 +0100, Lars Thegler =E9crivait :
 > | Erwin Lansing wrote:
 > |> Should Test::Simple be added as a dependencies or are you sure
 > |> it is only used by make test?
 > |=20
 > | Yes, Test::More is only used for testing. But I get your point - to sil=
 ence
 > | the warning, either the dependency should be added, or the Makefile.PL
 > | patched. What's best practice in these cases?
 >=20
 > As far as I can tell, there are good chances that Test::Simple is already
 > installed, but I would not bring a SOMETHING_DEPENDS if it does not really
 > depends on it. if a developper wants to make test, he's likely to have it
 > already, and if not, he's likely to be smart enough to find out how to ad=
 d it.
 > All this to say that I don't think adding a dependency just to shut up
 > Makefile.PL is a good thing.
 >=20
 I replied to Lars personally, but let me repeat it here.
 
 I have seen both cases, where the maintainer adds Test::Simple or just
 leaves the warning. Personally I add the dependency as I assume (most
 likely wrongly in several cases) that if the author tests for it, it
 needs it. But I'll leave it up to the maintainers discression to decide.
 
 -erwin
 
 --=20
                     _._     _,-'""`-._
 Erwin Lansing      (,-.`._,'(       |\`-/|    erwin at lansing.dk
 http://droso.org       `-.-' \ )-`( , o o)    erwin at FreeBSD.org
                     -bf-      `-    \`_`"'-
 
 --W/nzBZO5zC0uMSeA
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.4 (FreeBSD)
 
 iD8DBQFAI69Uqy9aWxUlaZARAsQbAKDfIAB+H97x6YEWdZ66wJmrd9GJ3gCg72Or
 nbOanXRsJzyuvS0+yCPMmnY=
 =8y3F
 -----END PGP SIGNATURE-----
 
 --W/nzBZO5zC0uMSeA--