ports/57272: [patch] COMMENT/COMMENTFILE checking is throwing errors

[Edwin Groothuis]

>Number:         57272
>Category:       ports
>Synopsis:       [patch] COMMENT/COMMENTFILE checking is throwing errors
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Fri Sep 26 23:40:16 PDT 2003
>Closed-Date:
>Last-Modified:
>Originator:     Edwin Groothuis
>Release:        FreeBSD 4.8-RELEASE i386
>Organization:
-
>Environment:
System: FreeBSD k7.mavetju 4.8-RELEASE FreeBSD 4.8-RELEASE #0: Sun Aug 17 16:04:25 EST 2003 edwin at k7.mavetju:/usr/src/sys/compile/k7 i386

>Description:

Make throws warnings when a port with pkg-comment and without COMMENT
is detected:

"/home/edwin/ports/Mk/bsd.port.mk", line 1857: warning: duplicate script for target ".BEGIN" ignored
"/home/edwin/ports/Mk/bsd.port.mk", line 1858: warning: duplicate script for target ".BEGIN" ignored
"/home/edwin/ports/Mk/bsd.port.mk", line 1859: warning: duplicate script for target ".BEGIN" ignored
"/home/edwin/ports/Mk/bsd.port.mk", line 1860: warning: duplicate script for target ".BEGIN" ignored
"/home/edwin/ports/Mk/bsd.port.mk", line 1861: warning: duplicate script for target ".BEGIN" ignored
There is no COMMENT variable defined
for this port. Please, rectify this.
*** Error code 1

This is only on -current, not on 4.8

>How-To-Repeat:

obvious

>Fix:

diff -u -r1.468 bsd.port.mk
--- bsd.port.mk 3 Sep 2003 19:50:24 -0000       1.468
+++ bsd.port.mk 27 Sep 2003 06:27:38 -0000
@@ -1851,7 +1851,7 @@
                @${ECHO_CMD} 'There is no COMMENT variable defined'
                @${ECHO_CMD} 'for this port. Please, rectify this.'
                @${FALSE}
-.endif
+.else
 .if exists(${COMMENTFILE})
 .BEGIN:
                @${ECHO_CMD} 'There is a COMMENTFILE in this port.'
@@ -1859,6 +1859,7 @@
                @${ECHO_CMD} 'favor of COMMENT variables.'
                @${ECHO_CMD} 'Please, rectify this.'
                @${FALSE}
+.endif
 .endif
 
 # Popular master sites

>Release-Note:
>Audit-Trail:
>Unformatted: