ports/58994: audio/cdparanoia: Change SCSI devices from cd0c to cd0, etc.

[Simon Barner]

>Number:         58994
>Category:       ports
>Synopsis:       audio/cdparanoia: Change SCSI devices from cd0c to cd0, etc.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Nov 06 02:00:39 PST 2003
>Closed-Date:
>Last-Modified:
>Originator:     Simon Barner
>Release:        FreeBSD 4.9-PRERELEASE i386
>Organization:
>Environment:
System: FreeBSD zi025.glhnet.mhn.de 4.9-PRERELEASE FreeBSD 4.9-PRERELEASE #1: Thu Sep 4 20:49:53 CEST 2003 simon at zi025.glhnet.mhn.de:/usr/src/sys/compile/KISTE i386

>Description:

As pointed out by grog@ in 

http://freebsd.rambler.ru/bsdmail/freebsd-questions_curr/msg00410.html

this patch changes the SCSI CDROM devices from cd0c to cd0. The former
device names do not make any sense, since CDROMs don't have a BSD label.

Since you are reading this message you should also have a look at
ports/57226 which addresses recent cooked I/O problems.

The latest version of that patch is available here (my follow-up does
not appear in GNATs).

http://home.leo.org/~barner/freebsd/cdparanoia-pread.patch

>How-To-Repeat:

Run cdparanoia -Qv on a system with a SCSI cdrom or on a ATAPICAM system
where /dev/cdrom does not point to /dev/acd0.

The output will look like this:

cdparanoia III release 9.8 (March 23, 2001)
(C) 2001 Monty <monty at xiph.org> and Xiphophorus
FreeBSD porting (c) 2003
        Simon 'corecode' Schubert <corecode at corecode.ath.cx>

Report bugs to paranoia at xiph.org
http://www.xiph.org/paranoia/

Checking /dev/cd0c for cdrom...

CDROM model sensed: HL-DT-ST RW/DVD GCC-4120B 2.02 

[...]

>Fix:

--- files/patch-interface-scan_devices.c.orig	Fri Jan 10 02:06:33 2003
+++ files/patch-interface-scan_devices.c	Thu Nov  6 10:38:56 2003
@@ -1,11 +1,5 @@
-Index: interface/scan_devices.c
-===================================================================
-RCS file: /home/cvs/cdparanoia/interface/scan_devices.c,v
-retrieving revision 1.1.1.1
-retrieving revision 1.10
-diff -u -r1.1.1.1 -r1.10
---- interface/scan_devices.c	2003/01/05 09:46:26	1.1.1.1
-+++ interface/scan_devices.c	2003/01/07 00:49:01	1.10
+--- interface/scan_devices.c.orig	Mon Mar 26 07:44:01 2001
++++ interface/scan_devices.c	Thu Nov  6 10:38:27 2003
 @@ -1,6 +1,8 @@
  /******************************************************************
   * CopyPolicy: GNU Public License 2 applies
@@ -30,10 +24,10 @@
    "/dev/optcd",NULL};
 +#elif defined(__FreeBSD__)
 +static char *cdrom_devices[] = {
-+	"/dev/cd?c",
-+	"/dev/acd?c",
-+	"/dev/wcd?c",
-+	"/dev/mcd?c", NULL};
++	"/dev/cd?",
++	"/dev/acd?",
++	"/dev/wcd?",
++	"/dev/mcd?", NULL};
 +#endif
  
  /* Functions here look for a cdrom drive; full init of a drive type
>Release-Note:
>Audit-Trail:
>Unformatted: