ports/58942: reliability fix for holyshout port

[Joel Sutton]

>Number:         58942
>Category:       ports
>Synopsis:       reliability fix for holyshout port
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Nov 04 17:50:18 PST 2003
>Closed-Date:
>Last-Modified:
>Originator:     Joel Sutton
>Release:        FreeBSD 4.8-RELEASE-p13 i386
>Organization:
>Environment:
System: FreeBSD solsbury-hill.off.jumpsoft.com.au 4.8-RELEASE-p13 
FreeBSD 4.8-RELEASE-p13 #1: Thu Oct 9 11:29:46 EST 2003 root at solsbury-
hill.off.jumpsoft.com.au:/usr/obj/usr/src/sys/NOKBD i386

>Description:
Holyshout includes an older copy of libshout which has been causing 
reliability problems when connecting to icecast with the mpg123 
client. The
most common issue is that mpg123 would exit with an error when 
holyshout 
started streaming the next track in the playlist.

I've included a fix to update the port to use the version of libshout
that is in the 4.8-RELEASE ports tree. This, of course, fixes the 
problem.
I'm very rusty on creating/maintaining ports so I hope this gives you 

enough to sort things out. 

Thanks, Joel...

>How-To-Repeat:
Install holyshout and icecast. Stream mp3 files, collected with 
ripit, to 
the icecast server. Use either the mpg123 version included in the 
4.8-RELEASE ports collection, or the latest version from the mpg123 
web 
site, to listen to the results.
>Fix:

Apply the following patch to the port Makefile:

*** Makefile.orig       Sun Jun 15 12:59:22 2003
--- Makefile    Sun Jun 15 13:01:01 2003
***************
*** 7,12 ****
--- 7,13 ----

  PORTNAME=     holyshout
  PORTVERSION=  0.1.3
+ PORTREVISION= 1
  CATEGORIES=   audio net
  MASTER_SITES= ftp://ftp.holywar.net/pub/FreeBSD/

***************
*** 15,20 ****
--- 16,23 ----

  USE_GMAKE=    yes
  USE_REINPLACE=        yes
+
+ LIB_DEPENDS+=   shout.2:${PORTSDIR}/audio/libshout

  post-patch:
        (find ${WRKSRC} -name Makefile | xargs ${REINPLACE_CMD} -e \


Include the following patches in the files directory:

--- holyshout.h.orig    Sun Jun 15 12:52:29 2003
+++ holyshout.h Sun Jun 15 12:54:12 2003
@@ -46,7 +46,7 @@
 #include <sys/socket.h>
 #include <netinet/in.h>

-#include "libshout/shout.h"
+#include "shout/shout.h"
 #include "liblame/lame.h"

 #define VERSION "HOLYSHOUT VERSION 0.1.3"


--- Makefile.orig       Sun Jun 15 12:36:03 2003
+++ Makefile    Sun Jun 15 12:57:34 2003
@@ -45,15 +45,15 @@
 # CAUTION: this Makefile doesn't work if your $HOME contains 
whitespaces!

 CC     = gcc
-CFLAG  += -O2 -fomit-frame-pointer -funroll-all-loops -g -L. -
Lliblame -lm -lnc
urses -lmp3lame libshout/.libs/libshout.a
+CFLAG  += -O -pipe  -fomit-frame-pointer -funroll-all-loops -g -
Lliblame -lm -l
ncurses -lmp3lame -I/usr/local/include -L/usr/local/lib -lshout
 PROG   = holyshout
 DESTDIR        = /usr/local/bin/
 RM = /bin/rm -f

-all: liblame libshout holyshout
+all: liblame holyshout


-holyshout : holyshout.c liblame libshout
+holyshout : holyshout.c liblame
        cd liblame ; gmake ;
        cd libshout ; gmake ;
        ${CC} -o holyshout holyshout.c ${CFLAG}


>Release-Note:
>Audit-Trail:
>Unformatted: