ports/52791: Ted-2.14 crashes when saving help page

[Jonathan]

>Number:         52791
>Category:       ports
>Synopsis:       Ted-2.14 crashes when saving help page
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu May 29 15:50:12 PDT 2003
>Closed-Date:
>Last-Modified:
>Originator:     Jonathan Drews
>Release:        FreeBSD 4.8-STABLE i386
>Organization:
<organization of PR author (multiple lines)>
>Environment:
System: FreeBSD analytic.engine 4.8-STABLE FreeBSD 4.8-STABLE #0: Sun May 25 
17:04:28 CDT
2003 root at analytic.engine:/usr/obj/usr/src/sys/STABLE_48 i386

 
>Description:
Ted will crash if you try to save the help document (TedDocument-en_US.rtf) as 
a *.ps file.

        
>How-To-Repeat:

1) Click on  Help->Document and open TedDocument-en_US.rtf
2) Click on File->Print and choose "Print to File"
3) Click on the Print button.
4) In the left hand "Directories" window, double click on 
/usr/X11R6/share/doc/..      to go up one directory.
5) Crash
        
>Fix:

To Fix apply this patch (supplied by Ted's developer Mark de Does) to the file 
appFileChooserMotif.c.  This file is in :
Ted-2.14/appFrame/appFileChooserMotif.c


I retested Ted-2.14 and the patch ahs fixed the problem.



--Boundary-00=_i5o1+JN93+OR2Ir
Content-Type: text/x-diff;
  charset="us-ascii";
  name="appFileChooserMotif.c.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="appFileChooserMotif.c.diff"

--- appFileChooserMotif.c	Fri Apr  4 06:46:48 2003
+++ /home/bsd/appFileChooserMotif.c	Thu May 29 17:02:44 2003
@@ -549,6 +549,7 @@
 static int appMakeFileChooser( AppChooserInformation **	pAci,
 				Widget				relative,
 				EditApplication *		ea,
+				int				withFilter,
 				const char *			defaultFilter,
 				Widget				option )
     {
@@ -624,15 +625,21 @@
 			NULL );
 
     /*  Not necessary
-    XtAddCallback( text, XmNactivateCallback,
+    if  ( withFilter )
+	{
+	XtAddCallback( text, XmNactivateCallback,
 				    appFileFilterActivated, (void *)aci );
+	}
     */
 
     filterButton= XmFileSelectionBoxGetChild( aci->aciDialog.adDialog,
 						    XmDIALOG_APPLY_BUTTON );
 
-    XtAddCallback( filterButton, XmNactivateCallback,
+    if  ( withFilter )
+	{
+	XtAddCallback( filterButton, XmNactivateCallback,
 				    appFileFilterActivated, (void *)aci );
+	}
 
     text= XmFileSelectionBoxGetChild( aci->aciDialog.adDialog, XmDIALOG_TEXT );
     XtVaSetValues( text,
@@ -705,14 +712,15 @@
 			EditApplication *	ea )
     {
     AppChooserInformation *	aci= (AppChooserInformation *)0;
+    const int			withFilter= extensionCount > 0;
 
-    if  ( appMakeFileChooser( &aci, relative, ea, defaultFilter, option ) )
+    if  ( appMakeFileChooser( &aci, relative, ea, withFilter, defaultFilter, option ) )
 	{ LDEB(1); return;	}
 
     XtAddCallback( aci->aciDialog.adDialog,
 			XmNokCallback, appOpenChooserOk, (XtPointer)aci );
 
-    if  ( extensionCount > 0 )
+    if  ( withFilter )
 	{
 	appFileMakeFilter( aci );
 
@@ -727,7 +735,7 @@
     aci->aciOpenDocument= openDocument;
     aci->aciFilename= (char *)0;
 
-    if  ( extensionCount > 0 )
+    if  ( withFilter )
 	{
 	WidgetList		children;
 	Cardinal		childCount= 0;
@@ -920,16 +928,17 @@
 				char **			pFilename )
     {
     AppChooserInformation *	aci= (AppChooserInformation *)0;
+    const int			withFilter= ea->eaFileExtensionCount > 0;
     int				response;
 
-    if  ( appMakeFileChooser( &aci, relative, ea,
+    if  ( appMakeFileChooser( &aci, relative, ea, withFilter,
 					    ea->eaDefaultFileFilter, option ) )
 	{ return ACIrespFAILURE;	}
 
     XtAddCallback( aci->aciDialog.adDialog,
 			    XmNokCallback, appSaveOkPushed, (XtPointer)aci );
 
-    if  ( ea->eaFileExtensionCount > 0 )
+    if  ( withFilter )
 	{
 	appFileMakeFilter( aci );
 
@@ -977,9 +986,10 @@
 					char **			pFilename )
     {
     AppChooserInformation *	aci= (AppChooserInformation *)0;
+    const int			withFilter= 0;
     int				response;
 
-    if  ( appMakeFileChooser( &aci, panel, ea, "*.ps", option ) )
+    if  ( appMakeFileChooser( &aci, panel, ea, withFilter, "*.ps", option ) )
 	{ LDEB(1); return ACIrespFAILURE;	}
 
     XtAddCallback( aci->aciDialog.adDialog,

--Boundary-00=_i5o1+JN93+OR2Ir--

>Release-Note:
>Audit-Trail:
>Unformatted:
 --Boundary-00=_i5o1+JN93+OR2Ir
 Content-Type: text/plain;
   charset="us-ascii"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 
 SEND-PR: -*- send-pr -*-
 SEND-PR: Lines starting with `SEND-PR' will be removed automatically, as
 SEND-PR: will all comments (text enclosed in `<' and `>').
 SEND-PR:
 SEND-PR: Please consult the following URL if you are not sure how to
 SEND-PR: fill out a problem report:
 SEND-PR: http://www.freebsd.org/doc/en/articles/problem-reports/article.html
 SEND-PR:
 SEND-PR: Note that the Synopsis field is mandatory.
 SEND-PR:
 SEND-PR: Please note that (unless you state otherwise) if your report
 SEND-PR: includes a patch then it will be taken under the same license as
 SEND-PR: the one on the file(s) you want to change.
 SEND-PR:
 SEND-PR: BE ADVISED THAT FREEBSD PROBLEM REPORTS ARE PUBLIC INFORMATION AND
 SEND-PR: WILL BE PUBLISHED AS-IS ON THE PROJECT'S MAILING LISTS AND WEB SITES.
 SEND-PR: DO NOT SUBMIT ANY INFORMATION YOU DO NOT WANT MADE PUBLIC.
 SEND-PR:
 SEND-PR: For sensitive security issues, consider contacting the FreeBSD
 SEND-PR: security officer team (security-officer at freebsd.org) directly.
 SEND-PR:
 SEND-PR: Choose from the following categories:
 SEND-PR:
 SEND-PR: advocacy  alpha     bin       conf      docs      gnu
 SEND-PR: i386      ia64      java      kern      misc      ports
 SEND-PR: powerpc   sparc64   standards www
 SEND-PR:
 To: FreeBSD-gnats-submit at freebsd.org
 From: Jonathan Drews
 Reply-To: j.e.drews at att.net
 Cc:
 X-send-pr-version: 3.113
 X-GNATS-Notify: