ports/56111: USE_RC_SUBR doesn't work as documented

[Oliver Eikemeier]

>Number:         56111
>Category:       ports
>Synopsis:       USE_RC_SUBR doesn't work as documented
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Aug 28 18:30:16 PDT 2003
>Closed-Date:
>Last-Modified:
>Originator:     Oliver Eikemeier
>Release:        FreeBSD 4.8-STABLE i386
>Organization:
Fillmore Labs - http://www.fillmore-labs.com
>Environment:
System: FreeBSD nuuk.fillmore-labs.com 4.8-STABLE

>Description:

USE_RC_SUBR is documented as:

# USE_RC_SUBR           - Says the ports startup/shutdown script uses the common
#                               routines found in etc/rc.subr and may need to
#                               depend on the sysutils/rc_subr port.
#
# RC_SUBR               - Set to path of rc.subr, defaults to /etc/rc.subr on
#                               5.x and to ${PREFIX}/etc/rc.subr on non-rcNG
#                               systems.

but the definition in ports/Mk/bsd.port.mk is:

.if defined(USE_RC_SUBR)
RUN_DEPENDS+=   ${LOCALBASE}/etc/rc.subr:${PORTSDIR}/sysutils/rc_subr
RC_SUBR=        ${LOCALBASE}/etc/rc.subr
.endif

Which means that the port depends on sysutils/rc_subr, even on 5.x systems,
and RC_SUBR is ${LOCALBASE}/etc/rc.subr in any case.

>How-To-Repeat:
>Fix:

use the definition from PR ports/54116:

.if defined(USE_RC_SUBR)
.if exists(/etc/rc.subr)
RC_SUBR=	/etc/rc.subr
.else
RUN_DEPENDS+=	${LOCALBASE}/etc/rc.subr:${PORTSDIR}/sysutils/rc_subr
RC_SUBR=	${LOCALBASE}/etc/rc.subr
.endif
.endif

or the extended version from port net/openlap22-server:

.if defined(USE_RC_SUBR)
.if ${OSVERSION} >= 500038
RC_SUBR=	/etc/rc.subr
RC_DIR=		/etc/rc.d
RC_SUFX=
.else
RUN_DEPENDS+=   ${LOCALBASE}/etc/rc.subr:${PORTSDIR}/sysutils/rc_subr
RC_SUBR=        ${LOCALBASE}/etc/rc.subr
RC_DIR=		${LOCALBASE}/etc/rc.d
RC_SUFX=	.sh
.endif
.endif


>Release-Note:
>Audit-Trail:
>Unformatted: