maintainer-feedback requested: [Bug 249374] ports-mgmt/pkg: 1.15.4 cannot unroll hard links to copies, and still runs pkg-install after error

[bugzilla-noreply at freebsd.org]

Bugzilla Automation <bugzilla at FreeBSD.org> has asked freebsd-pkg (Nobody)
<pkg at FreeBSD.org> for maintainer-feedback:
Bug 249374: ports-mgmt/pkg: 1.15.4 cannot unroll hard links to copies, and
still runs pkg-install after error
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=249374



--- Description ---
Presume I have hardlinked files in my $STAGEDIR, say, sbin/example and
usr/local/sbin/example.

I can package them into the tarball (examplepkg-1.2.3_4,5.txz), and tar xvf
properly shows them as "link to".

Installing the package however can fail with "cross-device link" errors.

pkg should copy the file in that case. We can't make a global decision as to
where and how a package user will split their file systems, so we need to
prepare for unexpected device crossings.

also, in that situation, pkg then removes all files, but still tries to run
POST-INSTALL, which it should not.

The port shown to error as given below is not committed to any trees yet:

===>  Installing for e2fsprogs-1.45.6_4
===>  Checking if e2fsprogs is already installed
===>  Switching to root credentials for 'install' target
===>   Registering installation for e2fsprogs-1.45.6_4
Installing e2fsprogs-1.45.6_4...
pkg-static: Fail to create hardlink:
/usr/local/sbin/.pkgtemp.e2fsck.S4cGKN1JKu2i:Cross-device link
cp: /usr/local/etc/mke2fs.conf.dist: No such file or directory
pkg-static: POST-INSTALL script failed
*** Error code 70