maintainer-feedback requested: [Bug 239580] [patch] ports-mgmt/pkg builds pkg-static during staging phase

[bugzilla-noreply at freebsd.org]

Bugzilla Automation <bugzilla at FreeBSD.org> has asked freebsd-pkg mailing list
<pkg at FreeBSD.org> for maintainer-feedback:
Bug 239580: [patch] ports-mgmt/pkg builds pkg-static during staging phase
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239580



--- Description ---
There what seems to be an error in the Makefile.autosetup, which causes
pkg-static to be linked in during install-static stage, not during make all
stage, which violates porting guidelines. Attached patch fixes the issue.

00:08:38.439  ===>  Staging for pkg-1.11.1
00:08:38.439  ===>   Generating temporary packing list
[...]
00:08:38.439  install: DONTSTRIP set - will not strip installed binaries
00:08:38.439  cc -o pkg-static add.o alias.o annotate.o audit.o autoremove.o
backup.o check.o clean.o config.o create.o delete.o event.o fetch.o globals.o
info.o install.o lock.o main.o plugins.o query.o register.o repo.o rquery.o
search.o set.o shell.o shlib.o ssh.o stats.o update.o updating.o upgrade.o
utils.o version.o which.o -static  -fstack-protector-strong 
-L/tmp/usr/ports/ports-mgmt/pkg/work/pkg-1.11.1/libpkg -lpkg_flat  -lelf -ljail
-larchive -lbz2 -lz -llzma -lm -lssl -lcrypto -pthread -lutil
00:08:38.711  install -d -m 755
/tmp/usr/ports/ports-mgmt/pkg/work/stage/usr/local/sbin
00:08:38.711  install: DONTSTRIP set - will not strip installed binaries
00:08:38.711  install -s -m 755 pkg-static
/tmp/usr/ports/ports-mgmt/pkg/work/stage/usr/local/sbin/pkg-static