[Bug 209475] pf didn't check if enough free RAM for net.pf.states_hashsize

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Tue Jan 16 10:19:07 UTC 2018


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=209475

--- Comment #14 from fehmi noyan isi <fnoyanisi at yahoo.com> ---
(In reply to Kristof Provost from comment #13)

>> I do see why, because it's non-trivial to cope with allocation failures in that part of the code. It gets called from a VNET_SYSINIT(), so it doesn't have a reasonable way of aborting the initialisation.

So, does this come down to supplying a default value and re-attempting malloc()
again?

>> As an aside, the allocations should probably be changed to use mallocarray() too
Yes, that might help to avoid this bug, but I do not think FreeBSD has
mallocarray()?

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-pf mailing list