de-virtualize pf sysctls

Nikos Vassiliadis nvass at gmx.com
Wed Jun 19 23:52:11 UTC 2013


On 06/19/2013 03:39 PM, Gleb Smirnoff wrote:
> On Sun, Jun 16, 2013 at 01:13:55PM +0200, Nikos Vassiliadis wrote:
> N> >>> Please review this patch. These two variables are RO-tunables and
> N> >>> cannot be changed at runtime. As such, it is not useful to
> N> >>> virtualize them.
> N> >
> N> > This looks correct to me. Also, it looks like V_pf_hashmask and
> N> > V_pf_srchashmask can be de-virtualized then.
> N>
> N> Yes, taken care of on this version. I am not sure if I placed
> N> properly pf_hashmask and pf_srchashmask in pfvar.h.
> N>
> N> Please review, thanks.
>
> Thanks, Nikos.
>
> I committed the patch to the branch projects/pf/head. Can you
> please check out this branch and generate further pf+vimage related
> diffs against it?
>
> Once we finish and stabilize it, I will merge the branch to head.
>

Nice, I will create patches against this branch then.

Thanks too,

Nikos



More information about the freebsd-pf mailing list