[PATCH] GNU/kFreeBSD detection in PF

[Bjoern A. Zeeb]

On 30. Jan 2012, at 18:24 , Robert Millan wrote:

> 
> Hi,
> 
> Please consider attached patch (since it's so large you may find it
> easier to read with grep "^[+-]") to fix detection of GNU/kFreeBSD in PF.
> 
> Note: since this code is part of FreeBSD, the __FreeBSD_kernel__ macro
> may be relied on when <sys/param.h> has been included.  For simplicity,
> this patch switches __FreeBSD__ to __FreeBSD_kernel__ for C files while
> adding the #include <sys/param.h> if missing.
> 
> For header files, instead of adding a new #include I opted for checking
> both macros, to avoid header pollution.
> 
> This patch fixes most (but not all) __FreeBSD__ checks and adds missing
> #includes where appropiate, but doesn't change anything else.  Since the
> patch is so big, I wanted to keep it as simple as possible.


As posted previously to freebsd-pf we shall unifdef pf as soon as someone
get some other work in, so the entire #ifdef __FreeBSD__ checks would be
gone.

I think that's a lot better solution than further mangling things.

/bz

-- 
Bjoern A. Zeeb                                 You have to have visions!
   It does not matter how good you are. It matters what good you do!