[pf4freebsd] Re: pfflowd port

[Max Laier]

On Tuesday 24 February 2004 01:15, Andrew Thompson wrote:
> Hi all,
>
> I have created a port for pfflowd and thought i'd get feedback before
> submitting a PR.
>
> It can be found @
>
> http://www.fud.org.nz/pfflowd-port.tar.gz

Okay, some feedback:
1) You copied from security/pf (which is okay), but you should update the 
pkg-descr.
2) pkg-plist is empty, but should contain:
sbin/pfflowd
etc/rc.d/pfflowd.sh.sample
3) Not sure what the patch for pfflowd.c should do. What is wrong with the 
check for invalid ports?
4) Maybe get the pidfile.{c,h} from us (include/support/) and add them 
instead of just removing <util.h> and pidfile support.

-- 
Best regards,				| mlaier at freebsd.org
Max Laier				| ICQ #67774661
http://pf4freebsd.love2party.net/	| mlaier at EFnet