maintainer-feedback requested: [Bug 231299] databases/p5-DBD-mysql: Does not compile with MariaDB 10.1

[bugzilla-noreply at freebsd.org]

Bugzilla Automation <bugzilla at FreeBSD.org> has asked freebsd-perl mailing list
<perl at FreeBSD.org> for maintainer-feedback:
Bug 231299: databases/p5-DBD-mysql: Does not compile with MariaDB 10.1
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231299



--- Description ---
Hi,

after the update to 4.047 the port doesn't compile with MariaDB installed:

--- dbdimp.o ---
dbdimp.c:1910:56: error: invalid token at start of a preprocessor expression
#if (MYSQL_VERSION_ID >= 50723) && (MYSQL_VERSION_ID < MARIADB_BASE_VERSION)
						       ^
/usr/local/include/mysql/mysql_version.h:16:31: note: expanded from macro
'MARIADB_BASE_VERSION'
#define MARIADB_BASE_VERSION		"mariadb-10.1"
					^
dbdimp.c:1917:56: error: invalid token at start of a preprocessor expression
#if (MYSQL_VERSION_ID >= 50600) && (MYSQL_VERSION_ID < MARIADB_BASE_VERSION)
						       ^
/usr/local/include/mysql/mysql_version.h:16:31: note: expanded from macro
'MARIADB_BASE_VERSION'
#define MARIADB_BASE_VERSION		"mariadb-10.1"


Full poudriere log at:
https://pkgs.blumenschaender.de/data/112amd64-default-desk/2018-09-11_04h09m16s
/logs/errors/p5-DBD-mysql-4.047.log

There is already a bug report open upstream:
https://github.com/perl5-dbi/DBD-mysql/issues/262 

The code in question was introduced with commit
f4b0004ea5422ed724a252be07731f0bd8c24c79.

I'm not quite sure what the author had in mind here and there is also no
MARIADB equivalent to MYSQL_VERSION_ID in
/usr/local/include/mysql/mysql_version.h. So i've not come up with a
workaround, yet.