[Bug 193934] New: Mk/Uses/perl5.mk causes bogus "*** Error code 1 (ignored)"

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193934

            Bug ID: 193934
           Summary: Mk/Uses/perl5.mk causes bogus "*** Error code 1
                    (ignored)"
           Product: Ports Tree
           Version: Latest
          Hardware: Any
                OS: Any
            Status: Needs Triage
          Severity: Affects Some People
          Priority: ---
         Component: Infrastructure
          Assignee: perl at FreeBSD.org
          Reporter: mandree at FreeBSD.org
                CC: marino at FreeBSD.org, perl at FreeBSD.org
 Attachment #147679 maintainer-approval?(perl at FreeBSD.org)
             Flags:
                CC: perl at FreeBSD.org

Created attachment 147679
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=147679&action=edit
Fix bogus *** Error 1 (ignored) and reinstate error check for ${FIND}/${SED}.

ports/Mk/Uses/perl5.mk abuses shell list sequencing with "&&" operators, and
this causes bogus errors in make on ports that run fix-packlist without the
SITE_PERL_REL/PERL_ARCH/auto dir installed, for instance, marino's upcoming
net-mgmt/netdisco port.

The syntax goes along these lines:

- at a && b

But if "a" failing isn't an error, then instead we should write:

if a ; then b ; fi

This will also ensure that errors from b are NOT ignored (they are now).

Proposed patch attached.  Please check if this needs an -exp run.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.