lang/perl5.16: fix the build of x11/rxvt-unicode on -CURRENT

[Thierry Thomas]

>Submitter-Id:	current-users
>Originator:	Thierry Thomas
>Organization:	Kabbale Eros
>Confidential:	no 
>Synopsis:	lang/perl5.16: fix the build of x11/rxvt-unicode on -CURRENT
>Severity:	serious
>Priority:	medium
>Category:	ports
>Class:		sw-bug
>Release:	FreeBSD 10.0-STABLE amd64
>Environment:
System: FreeBSD graf.pompo.net 10.0-STABLE FreeBSD 10.0-STABLE #0 r261650: Sun Feb 9 17:56:57 CET 2014 thierry at graf.pompo.net:/usr/obj/usr/src/sys/GRAF140209 amd64


>Description:

The compilation of x11/rxvt-unicode fails with clang34 (i.e. ATM on
-CURRENT) with the following message:

 --- rxvtperl.o ---
c++ -I.. -I. -I. -I./../libev -I./../libptytty/src -DHAVE_CONFIG_H
-I/usr/local/include -D_THREAD_SAFE -I/usr/local/include   -D_THREAD_SAFE
-I/usr/local/include  -I/usr/local/include/freetype2   -I/usr/local/include
 -I/usr/local/include/freetype2 -O2 -pipe -fno-strict-aliasing -w
-I/usr/local/include -I/usr/local/include/gdk-pixbuf-2.0 -pthread
-I/usr/local/include/glib-2.0 -I/usr/local/include
-I/usr/local/include/libpng15
-DAPPLLIB_EXP="/usr/local/lib/perl5/5.16/BSDPAN" -DHAS_FPSETMASK
-DHAS_FLOATINGPOINT_H -fno-strict-aliasing -pipe -fstack-protector
-I/usr/local/include  -I/usr/local/lib/perl5/5.16/mach/CORE
-DLIBDIR="\"/usr/local/lib/urxvt\"" -c rxvtperl.C
--- rxvtc ---
c++  -o rxvtc rxvtc.o rxvtdaemon.o fdpass_wrapper.o -lstdc++ -lutil -lm
--- rxvtperl.o ---
./rxvtperl.c:5493:5: error: declaration of 'Perl___notused' has a different
language linkage
    dVAR; dXSARGS;
    ^
/usr/local/lib/perl5/5.16/mach/CORE/perl.h:174:17: note: expanded from
macro 'dVAR'
#  define dVAR          dNOOP

The file rxvtperl.C is generated by xsubpp from rxvtperl.xs, and it can
be fixed in ExtUtils/ParseXS.pm by the hereunder patch.

>How-To-Repeat:
	Either build x11/rxvt-unicode on -CURRENT or with clang34.

>Fix:
	This patch fixes the problem.

	/!\ It could have implications on other ports!

	Note: may be the other Perl ports should be fixed too?

--- perl5.16.diff begins here ---
diff -urN lang/perl5.16.orig/Makefile lang/perl5.16/Makefile
--- lang/perl5.16.orig/Makefile	2014-03-09 16:48:59.000000000 +0100
+++ lang/perl5.16/Makefile	2014-03-14 10:47:58.000000000 +0100
@@ -3,7 +3,7 @@
 
 PORTNAME=	perl
 PORTVERSION=	${PERL_VERSION}
-PORTREVISION=	7
+PORTREVISION=	8
 CATEGORIES=	lang devel perl5
 MASTER_SITES=	CPAN \
 		${MASTER_SITE_LOCAL:S/$/:local/} \
diff -urN lang/perl5.16.orig/files/patch-dist_ExtUtils-ParseXS_lib_ExtUtils_ParseXS.pm lang/perl5.16/files/patch-dist_ExtUtils-ParseXS_lib_ExtUtils_ParseXS.pm
--- lang/perl5.16.orig/files/patch-dist_ExtUtils-ParseXS_lib_ExtUtils_ParseXS.pm	1970-01-01 01:00:00.000000000 +0100
+++ lang/perl5.16/files/patch-dist_ExtUtils-ParseXS_lib_ExtUtils_ParseXS.pm	2014-03-14 10:28:35.000000000 +0100
@@ -0,0 +1,11 @@
+--- ./dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm.orig	2013-03-04 16:16:21.000000000 +0100
++++ ./dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm	2014-03-14 10:27:17.000000000 +0100
+@@ -508,7 +508,7 @@
+ #XS_EUPXS(XS_${Full_func_name}); /* prototype to pass -Wmissing-prototypes */
+ #XS_EUPXS(XS_${Full_func_name})
+ #[[
+-#    dVAR; dXSARGS;
++#    dXSARGS;
+ EOF
+     print Q(<<"EOF") if $ALIAS;
+ #    dXSI32;
--- perl5.16.diff ends here ---