ports/mail/p5-Mail-SpamAssassin throws away precious auto-whitelist

[Helge Oldach]

>Submitter-Id:	current-users
>Originator:	Helge Oldach
>Organization:	
>Confidential:	no 
>Synopsis:	ports/mail/p5-Mail-SpamAssassin throws away precious auto-whitelist
>Severity:	non-critical 
>Priority:	low 
>Category:	ports
>Class:		sw-bug 
>Release:	FreeBSD 9.1-679 i386
>Environment:

System: FreeBSD localhost 9.1-679 FreeBSD 9.1-679 #0: Thu Apr 25 11:40:01 CEST 2013 toor at localhost:/usr/obj/usr/src/sys/HMO i386

>Description:

With r319458 it was introduced to unconditionally remove
/var/spool/spamd. This has at lest three undesireable side effects:

1) /var/spool/spamd often contains precious databases, for instance
auto-whitelists collected over extended periods. These should certainly
not go away after uninstall.

2) /var/spool/spamd is the home directory of the "spamd" user; it is
created upon "mkuser spamd" and will be removed safely by a "rmuser
spamd". Actually the port deinstall advises to do so manually, so there
is absolutely no need to fiddle with it during automatic port deinstall.

3) Once /var/spool/spamd is removed after a (current) port deinstall, it
is gone and will not be recreated during a fresh port re-install. This
will lead to lots of error messages when running SpamAssassin under the
"spamd" user, because its home directory is gone. And the databases
mentioned above won't be re-created anyway...

>How-To-Repeat:

Deinstall, see if /var/spool/spamd is still there. It's not. :-(

>Fix:

Back out r319458.