p5-Mail-SpamAssassin and versioned BUILD_DEPS, please review

[Anton Berezin]

On Wed, Oct 05, 2005 at 04:48:11PM +0200, Volker Stolz wrote:
> I know that you should always update all pre-requisites for a port, but this
> one seems to be a good start to introduce versioned dependencies since I actually
> got bitten by this on one of my hosts :)
> 
> Please review!

Looks fine - except - pardon my ignorance - but does it really,
definitely require Net::DNS 0.53 and not anything below it?

> Index: Makefile
> ===================================================================
> RCS file: /usr/freebsdcvs/cvs-ports/ports/mail/p5-Mail-SpamAssassin/Makefile,v
> retrieving revision 1.81
> diff -u -u -r1.81 Makefile
> --- Makefile	30 Sep 2005 00:31:51 -0000	1.81
> +++ Makefile	5 Oct 2005 14:37:05 -0000
> @@ -17,7 +17,7 @@
>  MAINTAINER=	perl at FreeBSD.org
>  COMMENT=	A highly efficient mail filter for identifying spam
>  
> -BUILD_DEPENDS=	${SITE_PERL}/${PERL_ARCH}/Net/DNS.pm:${PORTSDIR}/dns/p5-Net-DNS \
> +BUILD_DEPENDS=	p5-Net-DNS>=0.53:${PORTSDIR}/dns/p5-Net-DNS \
>  		${SITE_PERL}/${PERL_ARCH}/HTML/Parser.pm:${PORTSDIR}/www/p5-HTML-Parser \
>  		${SITE_PERL}/Mail/Internet.pm:${PORTSDIR}/mail/p5-Mail-Tools
>  RUN_DEPENDS=	${BUILD_DEPENDS}

\Anton.
-- 
An undefined problem has an infinite number of solutions.
-- Robert A. Humphrey