AMD64 native OOo working with the last patch

[Carlos Fernando Assis Paniago]

Jung-uk Kim escreveu:
> On Wednesday 21 June 2006 06:27 pm, Carlos Fernando Assis Paniago 
> wrote:
>   
>> Hi. For the first time my OOo 2.0.3rc5 with the last patches from
>> Jung-uk Kim, is now working in my
>> FreeBSD 6.1 with the last updates... I need to test if this patch
>> does not broke the i386 instalation.
>>     
>
> You mean this patch, right?
>
> http://people.freebsd.org/~jkim/patch-sentinel
>
>   
>> Thanks Jung-uk Kim. Thanks /NAKATA Maho.
>>     
>
> Thanks for the feedback.
>
>   
>> I opened a very big document and everything until now is working...
>> We need more test, but this is a wonderfull idea, I don't need the
>> OOo from linux (32 bits) in emulation in my AMD64 machine..... It
>> works native....Hip hip Hurra......
>> /
>>     
>
> That's actually the reason why I started the porting and I finally 
> removed Linux binary from my hard disk yesterday. ;-)
>
> Jung-uk Kim
>   
/usr/ports/editors/openoffice.org-2.0/work/OOC680_m5/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx:58:1: 
warning: "NULL" redefined
In file included from ../../../inc/sv.h:40,
                 from ../../../inc/salframe.hxx:40,
                 from ../../../unx/inc/plugins/gtk/gtkframe.hxx:50,
                 from 
/usr/ports/editors/openoffice.org-2.0/work/OOC680_m5/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx:36:
/usr/ports/editors/openoffice.org-2.0/work/OOC680_m5/solver/680/unxfbsdx.pro/inc/tools/solar.h:59:1: 
warning: this is the location of the previous definition
if ( -e ../../../unxfbsdx.pro/slo/salnativewidgets-gtk.o) touch 
../../../unxfbsdx.pro/slo/salnativewidgets-gtk.obj
------------------------------

this means that the definition of NULL is in solar.h... lets find were 
is this file

m018# find . -name solar.h -print
./tools/inc/solar.h
./solver/680/unxfbsdx.pro/inc/tools/solar.h
m018#                        
that means that we need to look at tools/inc/solar.h
#undef NULL
#define NULL            0

than lets solve to
#undef NULL
#ifdef X86_64
#define NULL            0L
#else
#define NULL            0
#endif

Whit this I supose we can get a lit bit furter instead of your patches...
What do you thing about this?
To change your patch to this simple one?

Ok.. I have signed the license from sun (a long time ago, my name is 
twice in the list).

-- 
Paniago

--
Carlos F. A. Paniago			pan at cnptia.embrapa.br
http://www.cnptia.embrapa.br/		Fone: +55 (19) 3789-5815