[Bug 200236] [maintainer][patch] games/wesnoth: fix for some FreeBSD 10.1 builds

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200236

--- Comment #27 from Dmitry Marakasov <amdmi3 at FreeBSD.org> ---
(In reply to John Marino from comment #25)

> It's equally correct.  It also doesn't require changing USES so I don't get its considered more complex.   The outliers are FreeBSD 8 and 9.

Absolutely not, because OSVERSION checks do not take anything I've mentioned
into account, and are not future-proof, as compiler.mk can be easily tweaked to
e.g. support newer compiler versions.

> In reality there should be a standard macro / USES for this, it's a fairly common issue.

Pretty much yes, though it can be quite complex. Something along these lines:

USES=compiler:4.6+,clang:3.6+
USES=compiler:gcc:any,clang:no,c++11-lib

> Are you saying when you build it in ports, there is a good chance that libiconv is already installed for another reason and boost builds wrong outside of poudriere?  
>
> I think that's what you must mean.  I would think that would also be limited to a -CURRENT.

Yes, that's what I mean. And it's not limited to -CURRENT - it affects all
versions which have libiconv in base. That's 10.x for sure, not so sure for
9.x.

-- 
You are receiving this mail because:
You are on the CC list for the bug.