AW: tcp-testsuite into src?

[Scheffenegger, Richard]

>> Yeah, it's not a problem to use binaries from ports in /usr/tests.  As 
>> long as the tests can compile they can live in the base system.  Is 
>> there a strong incentive to import them? 
>
> The tests are just scripts, which can be executed by packetdrill, which is available in the ports tree.
>
>> Do they need to be adjusted for each release?
>
> It depends. If things like default timeouts or so change, then the tests need to be adapted.
>
> If we would have (and I guess we will) tests for loss recovery, then improvements to the code might also require changes to the tests.

Yes, I would really like to have the packetdrill scripts in the source tree. And a recipe, how to run a subtree from the test (e.g. the TCP tests) as part of a kernel build...

As I work on adding newer mechanisms into base stack TCP, I would be documenting these changes in microscopic timing etc in terms of test cases...

Right now, the test suite is organized in a similar layout of the source files. However, as UDP, TCP and SCTP all live in /sys/netinet, and the existing packetdrill scripts cover a lot of ground in various scenarios, I am wondering if it wouldn't be easier to have a subdirectory under /tests/sys/netinet/packetdrill/tcp which mirrors freebsd-net/tcp-testsuite

>
> Best regards
> Michael