[Bug 254366] Severe IPv6 TCP transfer issues on 13.0-RC2 with virtio network adapter
bugzilla-noreply at freebsd.org
bugzilla-noreply at freebsd.org
Thu Mar 18 20:33:20 UTC 2021
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=254366
--- Comment #18 from commit-hook at FreeBSD.org ---
A commit in branch main references this bug:
URL:
https://cgit.FreeBSD.org/src/commit/?id=d4697a6b56168876fc0ffec1a0bb1b24d25b198e
commit d4697a6b56168876fc0ffec1a0bb1b24d25b198e
Author: Michael Tuexen <tuexen at FreeBSD.org>
AuthorDate: 2021-03-18 20:25:47 +0000
Commit: Michael Tuexen <tuexen at FreeBSD.org>
CommitDate: 2021-03-18 20:32:20 +0000
vtnet: fix TSO for TCP/IPv6
The decision whether a TCP packet is sent over IPv4 or IPv6 was
based on ethertype, which works correctly. In D27926 the criteria
was changed to checking if the CSUM_IP_TSO flag is set in the
csum-flags and then considering it to be TCP/IPv4.
However, the TCP stack sets the flag to CSUM_TSO for IPv4 and IPv6,
where CSUM_TSO is defined as CSUM_IP_TSO|CSUM_IP6_TSO.
Therefore TCP/IPv6 packets gets mis-classified as TCP/IPv4,
which breaks TSO for TCP/IPv6.
This patch bases the check again on the ethertype.
This fix will be MFC instantly as discussed with re(gjb).
MFC after: instantly
PR: 254366
Sponsored by: Netflix, Inc.
Differential Revision: https://reviews.freebsd.org/D29331
sys/dev/virtio/network/if_vtnet.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--
You are receiving this mail because:
You are on the CC list for the bug.
More information about the freebsd-net
mailing list