[Bug 230996] em/igb: Intel i210/i350: ifconfig: enabling "vlanhwtag" renders VLAN on i210/i350 NICs unusable

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230996

--- Comment #26 from Kaho Toshikazu <kaho at elam.kais.kyoto-u.ac.jp> ---
(In reply to Kevin Bowling from comment #25)
I don't test review D30002, but I think it contains some inappropriate parts
relating in "1. Call down to the hw support routine on vlan register and
unregister events". 
I think that "call hw support" would not be solve the problem
but make other trouble. I think vlan register/unregister parts in current codes 
are not broken.

I think that using E1000_WRITE_REG_ARRAY directly is a obvious bug
which was introduced at iflib conversion. 
The driver stores a device specific function for writing vfta into
the e1000_write_vfta variable, and should use this variable
as a function of writing vfta.
At first, correcting only this area is a good course, I think.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.