[Bug 254333] [tcp] sysctl net.inet.tcp.hostcache.list hangs

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Fri Apr 16 20:46:17 UTC 2021


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=254333

--- Comment #33 from commit-hook at FreeBSD.org ---
A commit in branch stable/13 references this bug:

URL:
https://cgit.FreeBSD.org/src/commit/?id=4052275c2fc5f96b4a208404733713959afe68f6

commit 4052275c2fc5f96b4a208404733713959afe68f6
Author:     Richard Scheffenegger <rscheff at FreeBSD.org>
AuthorDate: 2021-04-01 08:00:32 +0000
Commit:     Richard Scheffenegger <rscheff at FreeBSD.org>
CommitDate: 2021-04-16 19:44:00 +0000

    tcp: For hostcache performance, use atomics instead of counters

    As accessing the tcp hostcache happens frequently on some
    classes of servers, it was recommended to use atomic_add/subtract
    rather than (per-CPU distributed) counters, which have to be
    summed up at high cost to cache efficiency in a hot codepath.

    PR: 254333
    MFC after: 2 weeks
    Sponsored by: NetApp, Inc.
    Reviewed By: #transport, tuexen, jtl
    Differential Revision: https://reviews.freebsd.org/D29522

    (cherry picked from commit 529a2a0f2765f6c57c50a5af6be242c03bf714e3)

 sys/netinet/tcp_hostcache.c | 24 +++++++++++-------------
 sys/netinet/tcp_hostcache.h |  2 +-
 2 files changed, 12 insertions(+), 14 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the freebsd-net mailing list