[Bug 250499] [tcp] Should we reject the packet with timestamp if no timestamp in SYN and SYN_ACK?

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Mon Nov 30 09:46:11 UTC 2020


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=250499

--- Comment #3 from commit-hook at FreeBSD.org ---
A commit references this bug:

Author: tuexen
Date: Mon Nov 30 09:45:45 UTC 2020
New revision: 368181
URL: https://svnweb.freebsd.org/changeset/base/368181

Log:
  MFC r367530:
  RFC 7323 specifies that:
  * TCP segments without timestamps should be dropped when support for
    the timestamp option has been negotiated.
  * TCP segments with timestamps should be processed normally if support
    for the timestamp option has not been negotiated.
  This patch enforces the above.
  Manually resolved merge conflicts.

  MFC 367891:
  Fix an issue I introuced in r367530: tcp_twcheck() can be called
  with to == NULL for SYN segments. So don't assume tp != NULL.
  Thanks to jhb@ for reporting and suggesting a fix.

  MFC r367946:
  Fix two occurences of a typo in a comment introduced in r367530.
  Thanks to lstewart@ for reporting them.

  PR:                   250499
  Reviewed by:          gnn, rrs
  Sponsored by:         Netflix, Inc.
  Differential Revision:        https://reviews.freebsd.org/D27148

Changes:
_U  stable/12/
  stable/12/sys/netinet/tcp_input.c
  stable/12/sys/netinet/tcp_stacks/rack.c
  stable/12/sys/netinet/tcp_syncache.c
  stable/12/sys/netinet/tcp_timewait.c

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the freebsd-net mailing list