[Bug 248958] pptpd + vlan panic

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=248958

--- Comment #3 from Gleb Smirnoff <glebius at FreeBSD.org> ---
> https://reviews.freebsd.org/D26226

Right now reviews.freebsd.org is returning 502 for me, so I can't comment
there.

I believe the patch is incorrect there. In the new epoch synced network stack
the packet flow of netgraph shall all be covered by epoch. And eventually
netgraph internal synchronization shall be converted to epoch. Thus, this is
responsibility of an entrance nodes to enter the epoch, not the exit nodes.

ng_socket does that. However, there is one peculiarity, see r358193.

In this particular case what happens in ng_pppoe is that control message call
(not covered by epoch) sends a packet down the node, which should be covered by
epoch. So, this is ng_pppoe's ng_pppoe_rcvmsg() that needs to enter epoch until
some better solution is devised to address the problem described in r358193.

-- 
You are receiving this mail because:
You are the assignee for the bug.