[Differential] D20824: Fix netmap + vlan panics
vmaffione (Vincenzo Maffione)
phabric-noreply at FreeBSD.org
Mon Jul 1 19:52:59 UTC 2019
vmaffione accepted this revision.
vmaffione added a comment.
This revision is now accepted and ready to land.
Looks good, thanks.
The netmap unit tests and integration tests still pass with these changes.
As a side, using the netmap emulated adapter (aka generic) is rather slow, because of the translation layer between the netmap buffers and the mbufs. The right way to let netmap interact with VLANs would be to implement the VLAN strip/push operations in your netmap application, and always open physical ports (e.g. ix0). I know this is hard to do here, because the VALE switch is not easy to extend in kernel-space. In theory VALE could be ported to userspace, so that you can easily add custom logic for VLAN handling.
CHANGES SINCE LAST ACTION
https://reviews.freebsd.org/D20824/new/
REVISION DETAIL
https://reviews.freebsd.org/D20824
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: aleksandr.fedorov_itglobal.com, vmaffione, jhb, bz
Cc: olevole_olevole.ru, krion, evgueni.gavrilov_itglobal.com, freebsd-net-list
More information about the freebsd-net
mailing list