[Bug 231151] ifconfig: unable to disable rxcsum, rxcsum6 and vlanhwcsum on em driver

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231151

--- Comment #7 from Kaho Toshikazu <kaho at elam.kais.kyoto-u.ac.jp> ---
(In reply to Stephen Hurd from comment #5)

> +		mask &= ctx->ifc_softc_ctx.isc_capabilities;

An em class device doesn't have rxcsum6 capability and this line is useful.
If a device doesn't have rxcsum6 capability, don't touch a flag related rxcsum6
and the variable setmask should be also masked by isc_capabilities, I think. 

> It looks like there's some brokenness in the WoL stuff too. 

No, it is not broken. But the Wol feature doesn't have any effect until
shutdown
or suspend time, and set flags only and avoid re-initialization.

> I'm digging into that once I verify your vlan_hwcsum changes.

The vlan_hwcsum is simply forgot in the  definition IFCAP_FLAGS. 
If the IFCAP_FLAGS has the Wol flags, any special masking operation is not
need.

-- 
You are receiving this mail because:
You are the assignee for the bug.